Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate lines from project file. #4439

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@codemzs
Copy link
Member

codemzs commented Nov 5, 2019

fixes #4427

@codemzs codemzs requested a review from eerhardt Nov 5, 2019
@codemzs codemzs requested a review from dotnet/mlnet-core as a code owner Nov 5, 2019
Copy link
Member

eerhardt left a comment

Assuming the "stable API" checks still works, this looks good.

@codemzs

This comment has been minimized.

Copy link
Member Author

codemzs commented Nov 5, 2019

@eerhardt Verified: E:\machinelearning\packages\microsoft.dotnet.apicompat\1.0.0-beta.19225.5\build\Microsoft.DotNet.ApiCompat.targets(72,5): error : MembersMustExist : Member 'Microsoft.ML.ConversionsExtensionsCatalog.Hash(Microsoft.ML.TransformsCatalog.ConversionTransforms, System.String, System.String, System.Int32, System.Int32)' does not exist in the implementation but it does exist in the contract. [E:\machinelearning\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj]
E:\machinelearning\packages\microsoft.dotnet.apicompat\1.0.0-beta.19225.5\build\Microsoft.DotNet.ApiCompat.targets(84,5): error MSB3375: The file "E:\machinelearning\bin\obj\AnyCPU.Debug\Microsoft.ML.Data\netstandard2.0_AssemblyInfo.cs" does not exist. [E:\machinelearning\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj]

@codemzs codemzs merged commit ab1dc25 into dotnet:master Nov 6, 2019
15 of 19 checks passed
15 of 19 checks passed
MachineLearning-CI Build #20191105.1 had test failures
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build failed
Details
MachineLearning-CodeCoverage Build #20191105.1 failed
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug was canceled
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
frank-dong-ms added a commit to frank-dong-ms/machinelearning that referenced this pull request Nov 8, 2019
Remove duplicate lines from project file. (dotnet#4439)

Image Classification Sample cleanup (dotnet#4380)

* Aligned line ending to 85 char limit

* Cleaned up Early Stopping sample

* Added comments to ResnetV2101TransferLearningTrainTestSplit

* Added comments to ResnetV2101TransferLearningEarlyStopping

* Add comments to ImageClassificationDefault sample

* Added comments to LearningRateSchedulingCifarResnetTransferLearning sample

* added '.', formatted output.

* fixed sample after rebase

* fix ealy stopping sample

* fix GetAbsolutePath function for samples.

* remove unnecessary try catch block from samples.

* review comments.

Increment stable API version and add new stable packages to the list. (dotnet#4453)

* Increment stable API version and add new stable packages to the list.

* Increment stable API version and add new stable packages to the list.

also update template file

format template file

fix error in template

fix condition in template file

fix template format error

fix template parameter error

fix on template, seems corrupted when copy from github

fix placeholder

fix template error, encoding

fix template

fix in template file set system env

take comments and make adjustment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.