Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly build pipeline #4444

Merged

Conversation

frank-dong-ms-zz
Copy link
Contributor

new nightly build pipeline:

  1. add new nightly build pipeline project, disable project build from solution
  2. add NuGet package version updater project
  3. add new Azure nightly build pipeline and template file
  4. TestFrameworkCommon project use conditional reference to source code:
    a. when reference from functional test, use project reference
    b. when reference from nightly build test, use package reference
  5. process of nightly build pipeline:
    a. get latest NuGet package version from public NuGet feed
    b. update version to .props file
    c. build nightly build project
    d. run nightly build tests, which is functional test for now
    e. output test results
  6. a sample test pipeline can be seems here: https://dev.azure.com/dnceng/public/_build?definitionId=644&_a=summary

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #4444 into master will increase coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
+ Coverage   74.03%    74.7%   +0.67%     
==========================================
  Files         905      906       +1     
  Lines      159107   159288     +181     
  Branches    17128    17145      +17     
==========================================
+ Hits       117794   119000    +1206     
+ Misses      36545    35477    -1068     
- Partials     4768     4811      +43
Flag Coverage Δ
#Debug 74.7% <ø> (+0.67%) ⬆️
#production 70.06% <ø> (+0.88%) ⬆️
#test 90.12% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0%> (-20.52%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 71.42% <0%> (-8.41%) ⬇️
...rosoft.ML.AutoML/Utils/SweepableParamAttributes.cs 52.1% <0%> (-6.73%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 59.6% <0%> (-5.97%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...c/Microsoft.ML.SamplesUtils/SamplesDatasetUtils.cs 39.77% <0%> (ø)
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.26% <0%> (+0.15%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.31% <0%> (+0.2%) ⬆️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.05% <0%> (+0.84%) ⬆️
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 84.64% <0%> (+2.69%) ⬆️
... and 17 more

artifactName: parameters.name(_config_short)
artifactType: container
- ${{ if eq(parameters.buildScript, 'build.cmd') }}:
- powershell: |
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step to clean-up test data is not needed if you're not running any steps after running tests... the reason why we have it on CI builds is because we build packages after running tests and we need to cleanup space disk before we can do that to avoid failing because the machine ran out of space. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for explain, will remove


In reply to: 343775233 [](ancestors = 343775233)

@@ -0,0 +1,116 @@
parameters:
name: ''
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is very similar to the job-template.yml that we already have for CI builds. Would it make sense to instead use that template, and then define variables and steps based on a parameter passed down to the template? I.e: add a parameter called... isNightlyBuild: false (defaults to false)... then when you reference the template from the nightly build you pass that parameter down as true. Then in the template when isNightlyBuild == true you run the build and restore steps differently. That way you only maintain one base template file. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I saw what was done for codeCoverage, for nightly build, the logic difference is more as you can see there are 5 steps that is nightly build only, and there are several steps that nightly build don't need. So I use separate template here to keep the logic simple but I don't have strong preference here, let's discuss via a quick call.


In reply to: 343777088 [](ancestors = 343777088)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline discussed with Santiago, will merge these template file into


In reply to: 343828680 [](ancestors = 343828680,343777088)

<PackageReference Include="Microsoft.ML.Parquet" Version="0.17.0-preview-28305-3" />
<PackageReference Include="Microsoft.ML.Recommender" Version="0.17.0-preview-28305-3" />
</ItemGroup>
</Project>
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra line in EOF in all these files. #Resolved

@@ -0,0 +1,14 @@
<Project>
<ItemGroup>
<PackageReference Include="Microsoft.ML" Version="1.5.0-preview-28305-3" />
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan for updating these versions? I see only 2 package versions here, should we define a property for them and then use those properties here instead of hard-coding the versions? #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are only place holder, when running pipeline, the NugetPackageVersionUpdater will update all these out of date version number


In reply to: 343777962 [](ancestors = 343777962)

Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to instead use a placeholder? Rather than a hard-coded version? I think it deserves a comment explaining what happens so that people understand that we update it on the fly. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to restore project first to be able to list latest package versions, so use a placeholder will not work, I will put some comments here incase of confusion


In reply to: 343900725 [](ancestors = 343900725)

<ProjectReference Include="..\..\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
</ItemGroup>
<ItemGroup Condition="'$(ReferenceTypeForTestFramework)'=='NuGet'">
<PackageReference Include="Microsoft.ML" Version="1.5.0-preview-28305-3" />
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the shared property for the package version here as I suggested on my previous comment. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as pervious


In reply to: 343778600 [](ancestors = 343778600)

<ItemGroup Condition="'$(ReferenceTypeForTestFramework)'=='' OR '$(ReferenceTypeForTestFramework)'=='Project'">
<ProjectReference Include="..\..\src\Microsoft.ML.Data\Microsoft.ML.Data.csproj" />
</ItemGroup>
<ItemGroup Condition="'$(ReferenceTypeForTestFramework)'=='NuGet'">
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space before and after == #Resolved

@@ -0,0 +1,8 @@
<Project>
<ItemGroup Condition="'$(ReferenceTypeForTestFramework)'=='' OR '$(ReferenceTypeForTestFramework)'=='Project'">
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space before and after == #Resolved

- ${{ if eq(parameters.name, 'Ubuntu_x64_NetCoreApp21') }}:
- bash: echo "##vso[task.setvariable variable=LD_LIBRARY_PATH](nightlyBuildRunPath):LD_LIBRARY_PATH"
displayName: Set LD_LIBRARY_PATH for Ubuntu to locate Native shared library
- script: parameters.buildScript−(_configuration) -buildArch=${{ parameters.architecture }}
Copy link
Member

@safern safern Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prepend variables with $ to be consistent... (configuration) -> $(configuration)

Also in the rest of this file. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will do


In reply to: 343901037 [](ancestors = 343901037)

Remove duplicate lines from project file. (dotnet#4439)

Image Classification Sample cleanup (dotnet#4380)

* Aligned line ending to 85 char limit

* Cleaned up Early Stopping sample

* Added comments to ResnetV2101TransferLearningTrainTestSplit

* Added comments to ResnetV2101TransferLearningEarlyStopping

* Add comments to ImageClassificationDefault sample

* Added comments to LearningRateSchedulingCifarResnetTransferLearning sample

* added '.', formatted output.

* fixed sample after rebase

* fix ealy stopping sample

* fix GetAbsolutePath function for samples.

* remove unnecessary try catch block from samples.

* review comments.

Increment stable API version and add new stable packages to the list. (dotnet#4453)

* Increment stable API version and add new stable packages to the list.

* Increment stable API version and add new stable packages to the list.

also update template file

format template file

fix error in template

fix condition in template file

fix template format error

fix template parameter error

fix on template, seems corrupted when copy from github

fix placeholder

fix template error, encoding

fix template

fix in template file set system env

take comments and make adjustment
- script: ${{ parameters.buildScript }} -$(_configuration) -runtests -coverage=${{ parameters.codeCoverage }}
displayName: Run Tests.
condition: eq(${{ parameters.nightlyBuild }}, false)
Copy link
Member

@safern safern Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using runtime conditions, could you use compile time conditions? That way when you're running on nightly build, the UI will only show the "real" steps and when in CI, the "real" CI steps. The way currently is, it will show a bunch of disabled steps, which makes harder to read the logs.

Compile time would be ${{ if eq(parameters.nightlyBuild, 'false') }} #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, will do, good suggestions


In reply to: 344278680 [](ancestors = 344278680)

Comment on lines 53 to 67
- ${{ if eq(parameters.nightlyBuild, 'true') }}:
- script: $(dotnetPath) restore $(nightlyBuildProjPath)
displayName: Restore nightly build project
- ${{ if eq(parameters.nightlyBuild, 'true') }}:
- script: $(dotnetPath) list $(nightlyBuildProjPath) package --source $(nugetFeed) --outdated > $(versionFilePath)
displayName: List latest package versions
- ${{ if eq(parameters.nightlyBuild, 'true') }}:
- script: $(dotnetPath) run --project $(packageUpdaterProjPath)
displayName: Update package version
- ${{ if eq(parameters.nightlyBuild, 'true') }}:
- script: $(dotnetPath) msbuild -restore $(nightlyBuildProjPath) /p:ReferenceTypeForTestFramework="Nuget" /p:Configuration=$(_configuration) /p:TargetArchitecture=${{ parameters.architecture }}
displayName: Build Nightly Build Project with latest package versions
- ${{ if eq(parameters.nightlyBuild, 'true') }}:
- script: ${{ parameters.buildScript }} -$(_configuration) -runnightlybuildtests
displayName: Run Nightly Build Tests
Copy link
Member

@safern safern Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should only use 1 if for all these lines. An if can have multiple tasks/blocks under it, it is just a matter of indentation.

Same for the false block. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, will do, thanks


In reply to: 344337822 [](ancestors = 344337822)

@frank-dong-ms-zz frank-dong-ms-zz merged commit 8884161 into dotnet:master Nov 9, 2019
Lynx1820 added a commit to Lynx1820/machinelearning that referenced this pull request Nov 14, 2019
commit a5e274ef8869576190bbb794360a5f56d998b470
Merge: b7db4fa d7f9996
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Nov 14 14:51:21 2019 -0800

    Merge branch 'onnx_bin_classifiers' of https://github.com/Lynx1820/machinelearning into onnx_bin_classifiers

commit b7db4fa
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 17:41:12 2019 +0000

    Added onnx export support for KeyToValueMappingTransformer (dotnet#4455)

commit f3e0f6b
Author: Eric Erhardt <eric.erhardt@microsoft.com>
Date:   Thu Nov 14 07:22:12 2019 -0600

    Fix a flaky Extensions.ML test. (dotnet#4458)

    * Fix a flaky Extensions.ML test.

    Make the reload model tests more resistant to timing changes.

    * PR feedback.

commit c1e190a
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 05:24:14 2019 +0000

    Added onnx export support for OptionalColumnTransform  (dotnet#4454)

    * Initial work for adding onnx export support for OptionalColumnTransform

    * Implemented support for optional initializers in OnnxTranformer to support OptionalColumnTransform

    * Fixed handling of double values and non-long numeric types

    * Removed redundant line

    * Updated review comment

commit f96761b
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 03:17:12 2019 +0000

    Fixed model saving and loading of OneVersusAllTrainer to include SoftMax (dotnet#4472)

    * Fixed model saving and loading of OneVersusAllTrainer to include SoftMax

    * Modified existing test to include SoftMax option

    * Modified test to verify both cases: when UseSoftmax is true and false

commit d45cc8a
Author: Jake <31937616+JakeRadMSFT@users.noreply.github.com>
Date:   Wed Nov 13 17:26:49 2019 -0800

    Add InternalsVisibleTo in AutoML and CodeGenerator for the assembly Microsoft.ML.ModelBuilder.AutoMLService.Gpu (dotnet#4474)

commit 5e83e23
Author: Eric Erhardt <eric.erhardt@microsoft.com>
Date:   Wed Nov 13 16:09:05 2019 -0600

    CpuMathNative assembly is not getting copied when using packages.config. (dotnet#4465)

    When we refactored CpuMath to support netcoreapp3.0, we broke the packages.config support to copy the native assembly. This fixes it again by copying the file from the correct location.

    Fix dotnet#93

commit 693250b
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Wed Nov 13 21:58:07 2019 +0000

    Added onnx export support for WordTokenizingTransformer and NgramExtractingTransformer (dotnet#4451)

    * Added onnx export support for string related transforms

    * Updated baseline test files

    A large portion of this commit is upgrading the baseline test files. The rest of the fixes deal with build breaks resulting from the upgrade of ORT version.

    * Fixed bugs in ValueToKeyMappingTransformer and added additional tests

commit 5910910
Author: Antonio Velázquez <38739674+antoniovs1029@users.noreply.github.com>
Date:   Mon Nov 11 17:19:39 2019 -0800

    Fixes dotnet#4292 about using PFI with BPT and CMPB (dotnet#4306)

    *Changes in PredictionTransformer.cs and Calibrator.cs to fix the problem of the create methods not being called, to make CMP load its internal calibrator and predictor first so to assign the correct paramaters types and runtimes, and added a PredictionTransformerLoadTypeAttribute so that the binary prediction transformer knows what type to assign when loading a CMP as its internal model.
    *Added a working sample for using PFI with BPT and CMPB while loading a model from disk. This is based entirely in the original sample.
    *Added file CalibratedModelParametersTests.cs with tests that the CMPs modified in this PR are now being correctly loaded from disk.
    *Changed a couple of tests in LbfgsTests.cs that failed because they used casts that now return 'null'.

commit bcdac55
Author: Brian Stark <54910472+bpstark@users.noreply.github.com>
Date:   Mon Nov 11 13:42:42 2019 -0800

    Stabilize the LR test (dotnet#4446)

    * Stabilize the LR test

    Found issue with how we were using random for our
    ImageClassificationTrainer. This caused instability in our unit test, as
    we were not able to control the random seed. Modified the code to now
    use the same random object throughout, the trainer, thus allowing us to
    control the seed and therefor have predictable output.

commit d7f9996
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:33:17 2019 -0800

    workaround Scores

commit 7fba31c
Merge: 93388b6 c96d690
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:25:28 2019 -0800

    merging changes

commit 93388b6
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:19:59 2019 -0800

    Added extraction of score column before node creation

commit ea71828
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Fri Nov 8 15:53:11 2019 -0800

    fix for binary classification trainers export to onnx

commit 6fad293
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:26:43 2019 -0700

    Revert "draft regression test"

    This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.

commit 83c1c80
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:24:23 2019 -0700

    draft regression test

commit 8884161
Author: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com>
Date:   Fri Nov 8 20:20:53 2019 -0800

    nightly build pipeline (dotnet#4444)

    * nightly build pipeline

commit c96d690
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Fri Nov 8 15:53:11 2019 -0800

    fix for binary classification trainers export to onnx

commit 8100364
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:26:43 2019 -0700

    Revert "draft regression test"

    This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.

commit 81381e2
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:24:23 2019 -0700

    draft regression test
Lynx1820 added a commit to Lynx1820/machinelearning that referenced this pull request Dec 2, 2019
commit a5e274ef8869576190bbb794360a5f56d998b470
Merge: b7db4fa d7f9996
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Nov 14 14:51:21 2019 -0800

    Merge branch 'onnx_bin_classifiers' of https://github.com/Lynx1820/machinelearning into onnx_bin_classifiers

commit b7db4fa
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 17:41:12 2019 +0000

    Added onnx export support for KeyToValueMappingTransformer (dotnet#4455)

commit f3e0f6b
Author: Eric Erhardt <eric.erhardt@microsoft.com>
Date:   Thu Nov 14 07:22:12 2019 -0600

    Fix a flaky Extensions.ML test. (dotnet#4458)

    * Fix a flaky Extensions.ML test.

    Make the reload model tests more resistant to timing changes.

    * PR feedback.

commit c1e190a
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 05:24:14 2019 +0000

    Added onnx export support for OptionalColumnTransform  (dotnet#4454)

    * Initial work for adding onnx export support for OptionalColumnTransform

    * Implemented support for optional initializers in OnnxTranformer to support OptionalColumnTransform

    * Fixed handling of double values and non-long numeric types

    * Removed redundant line

    * Updated review comment

commit f96761b
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 03:17:12 2019 +0000

    Fixed model saving and loading of OneVersusAllTrainer to include SoftMax (dotnet#4472)

    * Fixed model saving and loading of OneVersusAllTrainer to include SoftMax

    * Modified existing test to include SoftMax option

    * Modified test to verify both cases: when UseSoftmax is true and false

commit d45cc8a
Author: Jake <31937616+JakeRadMSFT@users.noreply.github.com>
Date:   Wed Nov 13 17:26:49 2019 -0800

    Add InternalsVisibleTo in AutoML and CodeGenerator for the assembly Microsoft.ML.ModelBuilder.AutoMLService.Gpu (dotnet#4474)

commit 5e83e23
Author: Eric Erhardt <eric.erhardt@microsoft.com>
Date:   Wed Nov 13 16:09:05 2019 -0600

    CpuMathNative assembly is not getting copied when using packages.config. (dotnet#4465)

    When we refactored CpuMath to support netcoreapp3.0, we broke the packages.config support to copy the native assembly. This fixes it again by copying the file from the correct location.

    Fix dotnet#93

commit 693250b
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Wed Nov 13 21:58:07 2019 +0000

    Added onnx export support for WordTokenizingTransformer and NgramExtractingTransformer (dotnet#4451)

    * Added onnx export support for string related transforms

    * Updated baseline test files

    A large portion of this commit is upgrading the baseline test files. The rest of the fixes deal with build breaks resulting from the upgrade of ORT version.

    * Fixed bugs in ValueToKeyMappingTransformer and added additional tests

commit 5910910
Author: Antonio Velázquez <38739674+antoniovs1029@users.noreply.github.com>
Date:   Mon Nov 11 17:19:39 2019 -0800

    Fixes dotnet#4292 about using PFI with BPT and CMPB (dotnet#4306)

    *Changes in PredictionTransformer.cs and Calibrator.cs to fix the problem of the create methods not being called, to make CMP load its internal calibrator and predictor first so to assign the correct paramaters types and runtimes, and added a PredictionTransformerLoadTypeAttribute so that the binary prediction transformer knows what type to assign when loading a CMP as its internal model.
    *Added a working sample for using PFI with BPT and CMPB while loading a model from disk. This is based entirely in the original sample.
    *Added file CalibratedModelParametersTests.cs with tests that the CMPs modified in this PR are now being correctly loaded from disk.
    *Changed a couple of tests in LbfgsTests.cs that failed because they used casts that now return 'null'.

commit bcdac55
Author: Brian Stark <54910472+bpstark@users.noreply.github.com>
Date:   Mon Nov 11 13:42:42 2019 -0800

    Stabilize the LR test (dotnet#4446)

    * Stabilize the LR test

    Found issue with how we were using random for our
    ImageClassificationTrainer. This caused instability in our unit test, as
    we were not able to control the random seed. Modified the code to now
    use the same random object throughout, the trainer, thus allowing us to
    control the seed and therefor have predictable output.

commit d7f9996
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:33:17 2019 -0800

    workaround Scores

commit 7fba31c
Merge: 93388b6 c96d690
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:25:28 2019 -0800

    merging changes

commit 93388b6
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:19:59 2019 -0800

    Added extraction of score column before node creation

commit ea71828
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Fri Nov 8 15:53:11 2019 -0800

    fix for binary classification trainers export to onnx

commit 6fad293
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:26:43 2019 -0700

    Revert "draft regression test"

    This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.

commit 83c1c80
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:24:23 2019 -0700

    draft regression test

commit 8884161
Author: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com>
Date:   Fri Nov 8 20:20:53 2019 -0800

    nightly build pipeline (dotnet#4444)

    * nightly build pipeline

commit c96d690
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Fri Nov 8 15:53:11 2019 -0800

    fix for binary classification trainers export to onnx

commit 8100364
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:26:43 2019 -0700

    Revert "draft regression test"

    This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.

commit 81381e2
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:24:23 2019 -0700

    draft regression test
Lynx1820 added a commit that referenced this pull request Dec 2, 2019
* Squashed commit of the following:

commit a5e274ef8869576190bbb794360a5f56d998b470
Merge: b7db4fa d7f9996
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Nov 14 14:51:21 2019 -0800

    Merge branch 'onnx_bin_classifiers' of https://github.com/Lynx1820/machinelearning into onnx_bin_classifiers

commit b7db4fa
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 17:41:12 2019 +0000

    Added onnx export support for KeyToValueMappingTransformer (#4455)

commit f3e0f6b
Author: Eric Erhardt <eric.erhardt@microsoft.com>
Date:   Thu Nov 14 07:22:12 2019 -0600

    Fix a flaky Extensions.ML test. (#4458)

    * Fix a flaky Extensions.ML test.

    Make the reload model tests more resistant to timing changes.

    * PR feedback.

commit c1e190a
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 05:24:14 2019 +0000

    Added onnx export support for OptionalColumnTransform  (#4454)

    * Initial work for adding onnx export support for OptionalColumnTransform

    * Implemented support for optional initializers in OnnxTranformer to support OptionalColumnTransform

    * Fixed handling of double values and non-long numeric types

    * Removed redundant line

    * Updated review comment

commit f96761b
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Thu Nov 14 03:17:12 2019 +0000

    Fixed model saving and loading of OneVersusAllTrainer to include SoftMax (#4472)

    * Fixed model saving and loading of OneVersusAllTrainer to include SoftMax

    * Modified existing test to include SoftMax option

    * Modified test to verify both cases: when UseSoftmax is true and false

commit d45cc8a
Author: Jake <31937616+JakeRadMSFT@users.noreply.github.com>
Date:   Wed Nov 13 17:26:49 2019 -0800

    Add InternalsVisibleTo in AutoML and CodeGenerator for the assembly Microsoft.ML.ModelBuilder.AutoMLService.Gpu (#4474)

commit 5e83e23
Author: Eric Erhardt <eric.erhardt@microsoft.com>
Date:   Wed Nov 13 16:09:05 2019 -0600

    CpuMathNative assembly is not getting copied when using packages.config. (#4465)

    When we refactored CpuMath to support netcoreapp3.0, we broke the packages.config support to copy the native assembly. This fixes it again by copying the file from the correct location.

    Fix #93

commit 693250b
Author: Harish Kulkarni <harishsk@users.noreply.github.com>
Date:   Wed Nov 13 21:58:07 2019 +0000

    Added onnx export support for WordTokenizingTransformer and NgramExtractingTransformer (#4451)

    * Added onnx export support for string related transforms

    * Updated baseline test files

    A large portion of this commit is upgrading the baseline test files. The rest of the fixes deal with build breaks resulting from the upgrade of ORT version.

    * Fixed bugs in ValueToKeyMappingTransformer and added additional tests

commit 5910910
Author: Antonio Velázquez <38739674+antoniovs1029@users.noreply.github.com>
Date:   Mon Nov 11 17:19:39 2019 -0800

    Fixes #4292 about using PFI with BPT and CMPB (#4306)

    *Changes in PredictionTransformer.cs and Calibrator.cs to fix the problem of the create methods not being called, to make CMP load its internal calibrator and predictor first so to assign the correct paramaters types and runtimes, and added a PredictionTransformerLoadTypeAttribute so that the binary prediction transformer knows what type to assign when loading a CMP as its internal model.
    *Added a working sample for using PFI with BPT and CMPB while loading a model from disk. This is based entirely in the original sample.
    *Added file CalibratedModelParametersTests.cs with tests that the CMPs modified in this PR are now being correctly loaded from disk.
    *Changed a couple of tests in LbfgsTests.cs that failed because they used casts that now return 'null'.

commit bcdac55
Author: Brian Stark <54910472+bpstark@users.noreply.github.com>
Date:   Mon Nov 11 13:42:42 2019 -0800

    Stabilize the LR test (#4446)

    * Stabilize the LR test

    Found issue with how we were using random for our
    ImageClassificationTrainer. This caused instability in our unit test, as
    we were not able to control the random seed. Modified the code to now
    use the same random object throughout, the trainer, thus allowing us to
    control the seed and therefor have predictable output.

commit d7f9996
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:33:17 2019 -0800

    workaround Scores

commit 7fba31c
Merge: 93388b6 c96d690
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:25:28 2019 -0800

    merging changes

commit 93388b6
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Mon Nov 11 11:19:59 2019 -0800

    Added extraction of score column before node creation

commit ea71828
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Fri Nov 8 15:53:11 2019 -0800

    fix for binary classification trainers export to onnx

commit 6fad293
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:26:43 2019 -0700

    Revert "draft regression test"

    This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.

commit 83c1c80
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:24:23 2019 -0700

    draft regression test

commit 8884161
Author: frank-dong-ms <55860649+frank-dong-ms@users.noreply.github.com>
Date:   Fri Nov 8 20:20:53 2019 -0800

    nightly build pipeline (#4444)

    * nightly build pipeline

commit c96d690
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Fri Nov 8 15:53:11 2019 -0800

    fix for binary classification trainers export to onnx

commit 8100364
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:26:43 2019 -0700

    Revert "draft regression test"

    This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.

commit 81381e2
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Thu Oct 31 15:24:23 2019 -0700

    draft regression test

* update name and remove some dependency code

* baseline file changes

* Refactored function
@frank-dong-ms-zz frank-dong-ms-zz deleted the nightly-build-pipeline branch April 15, 2020 20:37
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants