Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes onnx exports for regression trainers #4448

Open
wants to merge 4 commits into
base: master
from

Conversation

@Lynx1820
Copy link
Member

Lynx1820 commented Nov 6, 2019

This PR fixes the issues with exporting the following regression trainers to onnx:

  • LbfgsPoissonRegression
  • FastTreeTweedie
  • FastForest

And adds onnx conversion tests for the following regression trainers:

  • FastTree
  • OnlineGradientDescent
  • Ols
  • LightGbm
  • Sdca
Lynx1820 added 2 commits Nov 6, 2019
commit fa5669b2a1c0026dc86741a0f5136809b6ffdf3b
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Wed Nov 6 13:06:30 2019 -0800

    Adding regression trainers conversion test

commit e89cf216907a9773e5845f595c32c842fe82bb27
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Wed Nov 6 10:17:52 2019 -0800

    Adding baseline files for regression trainers conversion test

commit 2f4dc1901a4aa80899d5eb66468f501b86d06ed0
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Tue Nov 5 14:15:13 2019 -0800

    fixed spelling in file

commit f6bea5f7cce0f549a4bd589d6ed0ed1f42628c38
Author: Keren Fuentes <dkeren@seas.upenn.edu>
Date:   Tue Nov 5 14:13:47 2019 -0800

    regression fix
@Lynx1820 Lynx1820 requested a review from dotnet/mlnet-core as a code owner Nov 6, 2019
@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Nov 6, 2019

CLA assistant check
All CLA requirements met.

@Lynx1820 Lynx1820 requested a review from harishsk Nov 6, 2019
@Lynx1820 Lynx1820 requested review from KsenijaS and dotnet/mlnet-core Nov 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #4448 into master will decrease coverage by 15.35%.
The diff coverage is 90.12%.

@@             Coverage Diff             @@
##           master    #4448       +/-   ##
===========================================
- Coverage   90.11%   74.76%   -15.36%     
===========================================
  Files         200      907      +707     
  Lines       36848   159507   +122659     
  Branches     1910    17159    +15249     
===========================================
+ Hits        33206   119251    +86045     
- Misses       3337    35446    +32109     
- Partials      305     4810     +4505
Flag Coverage Δ
#Debug 74.76% <90.12%> (-15.36%) ⬇️
#production 70.11% <100%> (?)
#test 90.14% <81.81%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.FastTree/FastTree.cs 80.64% <100%> (ø)
...StandardTrainers/Standard/LinearModelParameters.cs 61.06% <100%> (ø)
src/Microsoft.ML.FastTree/FastTreeTweedie.cs 58.02% <100%> (ø)
...rc/Microsoft.ML.FastTree/RandomForestRegression.cs 70.43% <100%> (ø)
test/Microsoft.ML.Tests/OnnxConversionTest.cs 93.44% <81.81%> (-0.74%) ⬇️
...soft.ML.Tests/PermutationFeatureImportanceTests.cs 100% <0%> (ø) ⬆️
src/Microsoft.ML.Data/Model/Pfa/ModelUtils.cs 0% <0%> (ø)
...ML.Data/Transforms/ColumnConcatenatingEstimator.cs 83.58% <0%> (ø)
src/Microsoft.ML.Data/Model/Pfa/PfaUtils.cs 0% <0%> (ø)
...t.ML.Data/DataLoadSave/CompositeLoaderEstimator.cs 80% <0%> (ø)
... and 705 more
@Lynx1820 Lynx1820 requested a review from ganik Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.