Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onnx export support for OptionalColumnTransform #4454

Merged
merged 5 commits into from Nov 14, 2019

Conversation

@harishsk
Copy link
Member

harishsk commented Nov 7, 2019

Optional columns in ML.NET are supported through initializers in Onnx runtime, support for which was added in the v1 release of ORT. This PR adds support for integrating initializers in ML.NET and adding the corresponding OptionalColumnTransform support in ML.NET.

@harishsk harishsk requested a review from dotnet/mlnet-core as a code owner Nov 7, 2019
@harishsk harishsk requested review from ganik, codemzs and wschin Nov 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5e83e23). Click here to learn what that means.
The diff coverage is 78.84%.

@@            Coverage Diff            @@
##             master    #4454   +/-   ##
=========================================
  Coverage          ?   74.74%           
=========================================
  Files             ?      906           
  Lines             ?   159345           
  Branches          ?    17155           
=========================================
  Hits              ?   119097           
  Misses            ?    35445           
  Partials          ?     4803
Flag Coverage Δ
#Debug 74.74% <78.84%> (?)
#production 70.1% <68.11%> (?)
#test 90.12% <100%> (?)
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Model/Onnx/OnnxContext.cs 100% <ø> (ø)
test/Microsoft.ML.Tests/OnnxConversionTest.cs 94.45% <100%> (ø)
src/Microsoft.ML.OnnxConverter/OnnxContextImpl.cs 72.57% <28.57%> (ø)
...Microsoft.ML.Transforms/OptionalColumnTransform.cs 77.08% <58.82%> (ø)
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 90.14% <89.28%> (ø)

// REVIEW:
// AddInitializer only supports long, float and string.
// Is it correct to cast double to float and ulong to long?

This comment has been minimized.

Copy link
@ganik

ganik Nov 13, 2019

Member

// Is it correct to cast double to float and ulong to long [](start = 11, length = 59)

State this as a known issue for future

@ganik
ganik approved these changes Nov 13, 2019
Copy link
Member

ganik left a comment

:shipit:

@harishsk harishsk force-pushed the harishsk:optionalcol2 branch from bd8ff75 to 3f10584 Nov 13, 2019
@harishsk harishsk merged commit c1e190a into dotnet:master Nov 14, 2019
17 of 19 checks passed
17 of 19 checks passed
MachineLearning-CodeCoverage Build #20191113.17 failed
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug was canceled
Details
MachineLearning-CI Build #20191113.17 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.