Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retro-fitted changes made to the ML docs repo into ML.NET #4457

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@harshithapv
Copy link
Member

harshithapv commented Nov 7, 2019

Retro-fitted changes made to the ML docs repository into ML.NET.

@harshithapv harshithapv requested review from codemzs and natke Nov 7, 2019
@natke
natke approved these changes Nov 7, 2019
@codemzs

This comment has been minimized.

Copy link
Member

codemzs commented Nov 8, 2019

@harshithapv Why is this PR still in draft?

@codemzs
codemzs approved these changes Nov 8, 2019
Copy link
Member

codemzs left a comment

:shipit:

@codemzs

This comment has been minimized.

Copy link
Member

codemzs commented Nov 8, 2019

Looks great! Thank you for doing such an amazing job!

@harshithapv harshithapv marked this pull request as ready for review Nov 8, 2019
@harshithapv harshithapv requested a review from dotnet/mlnet-core as a code owner Nov 8, 2019
@codemzs codemzs merged commit f7aaa5a into dotnet:master Nov 8, 2019
15 of 19 checks passed
15 of 19 checks passed
MachineLearning-CI Build #20191107.8 had test failures
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build failed
Details
MachineLearning-CodeCoverage Build #20191107.8 failed
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug was canceled
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.