Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a flaky Extensions.ML test. #4458

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@eerhardt
Copy link
Member

eerhardt commented Nov 7, 2019

Make the reload model tests more resistant to timing changes.

Make the reload model tests more resistant to timing changes.
@eerhardt eerhardt requested review from codemzs and safern Nov 7, 2019
@eerhardt eerhardt requested a review from dotnet/mlnet-core as a code owner Nov 7, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #4458 into master will increase coverage by 0.8%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #4458     +/-   ##
=========================================
+ Coverage   74.03%   74.83%   +0.8%     
=========================================
  Files         905      907      +2     
  Lines      159107   159697    +590     
  Branches    17128    17187     +59     
=========================================
+ Hits       117794   119509   +1715     
+ Misses      36545    35382   -1163     
- Partials     4768     4806     +38
Flag Coverage Δ
#Debug 74.83% <ø> (+0.8%) ⬆️
#production 70.19% <ø> (+1.01%) ⬆️
#test 90.17% <ø> (+0.05%) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.AutoML/Sweepers/ISweeper.cs 59.49% <0%> (-7.6%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 77.96% <0%> (-4.24%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 62.25% <0%> (-3.32%) ⬇️
test/Microsoft.ML.AutoML.Tests/DatasetUtil.cs 88.59% <0%> (-2.64%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 84.7% <0%> (-0.41%) ⬇️
...Microsoft.ML.Data/Scorers/PredictionTransformer.cs 90.88% <0%> (-0.2%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 79.83% <0%> (ø) ⬆️
...soft.ML.Tests/PermutationFeatureImportanceTests.cs 100% <0%> (ø) ⬆️
...c/Microsoft.ML.SamplesUtils/SamplesDatasetUtils.cs 39.77% <0%> (ø)
...crosoft.ML.Tests/CalibratedModelParametersTests.cs 100% <0%> (ø)
... and 31 more
#Resolved
@eerhardt

This comment has been minimized.

Copy link
Member Author

eerhardt commented Nov 11, 2019

@codemzs - thoughts on this? This test doesn't fail super often, but I've seen it fail enough to fix it here.

Copy link
Member

codemzs left a comment

:shipit:

@eerhardt eerhardt merged commit f3e0f6b into dotnet:master Nov 14, 2019
17 of 19 checks passed
17 of 19 checks passed
MachineLearning-CodeCoverage Build #20191113.16 failed
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug was canceled
Details
MachineLearning-CI Build #20191113.16 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@eerhardt eerhardt deleted the eerhardt:FixFlakyTests branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.