Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - CodeGen for Azure Attach Image #4497

Conversation

@LittleLittleCloud
Copy link
Contributor

LittleLittleCloud commented Nov 22, 2019

Transformer added:

  • ExtractPixel
  • NormalizeMapping
  • ResizeImage
  • ApplyOnnxModel

Notify that those are transformers that not exist in AutoML

@LittleLittleCloud LittleLittleCloud requested review from dotnet/mlnet-automl as code owners Nov 22, 2019
Xiaoyun Zhang
@@ -89,6 +90,53 @@ public void GenerateOutput()
Utils.AddProjectsToSolution(modelprojectDir, modelProjectName, consoleAppProjectDir, consoleAppProjectName, solutionPath);
}

public void GenerateAzureRemoteImageOutput()

This comment has been minimized.

Copy link
@LittleLittleCloud

LittleLittleCloud Nov 22, 2019

Author Contributor

Ideal way is we don't differentiate pipelines from AutoML / Azure AutoML, However there's already too many if-else conditions and some function's parameter list are so long to be bearable. So I feel like make it a special case can be a better choice

@@ -336,7 +336,7 @@ public ImageLoading(PipelineNode node) : base(node)
{
}

internal override string MethodName => "LoadRawImageBytes";

This comment has been minimized.

Copy link
@LittleLittleCloud

LittleLittleCloud Nov 22, 2019

Author Contributor

this transformer's name should be something like ImageLoadingRawBytes

@codemzs

This comment has been minimized.

Copy link
Member

codemzs commented Nov 22, 2019

@LittleLittleCloud Please do not use WIP tag instead use DRAFT PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.