Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Reenabling MacOS tests that had an issue with libgdiplus #4500
Edited First Post:
PR #4492 disabled some tests that threw a
As explained below in this thread, the problem was on homebrew's side, and this PR was meant to give a provitional solution for the problem. Nonetheless, this problem has just been fixed on homebrew's side, so now this PR simply reenables those tests.
Original First Post:
Solves the problem with MacOS Pipeline where certain tests threw a
The issue was caused somewhere in homebrew's installation, and one way to solve this issue is to actually make homebrew to build the libgdiplus library after downloading it (instead of downloading a prebuilt version from https://homebrew.bintray.com/bottles/mono-libgdiplus-6.0.4.high_sierra.bottle.tar.gz which is where it gets libgdiplus if homebrew doesn't build it). For some reason that's still unknown to me, this prebuilt version isn't working as expected, and the above exception is thrown.
@safern It seems this problem is not only affecting us.
For instance, I created a simple Hello World app on a MacBook with High Sierra, where I made use of System.Drawing's Bitmap, and it threw the same DllNotFoundException if I installed mono-libgdiplus with
... but it got fixed after I reinstalled mono-libgdiplus with
In fact, it seems that other homewbrew's contributors have become aware that there's an issue with mono-libgdiplus bottle, as pointed here in this thread on homebrew's repo. And it seems they are working on this, although I am not sure if it would be a good idea to open there an issue for this problem.
As kindly explained by @Bo98 on this comment on the homebrew-core repo, there were some problems with the libgdiplus prebuilt library that was downloaded when using
(notice the 6.0.4_1 which is used now, against the previous, problematic 6.0.4)
With those changes, it is no longer necessary to use the
That is, the problem was solved by Bo98 contributions on hombrew-core, and now this PR would simply reenable the tests that were failing on MacOS pipeline.