Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local functions static where applicable #4530

Merged
merged 1 commit into from Dec 8, 2019

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 6, 2019

No description provided.

@sharwell sharwell requested a review from a team as a code owner December 6, 2019 22:37
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #4530 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4530      +/-   ##
==========================================
+ Coverage    75.1%   75.11%   +<.01%     
==========================================
  Files         908      908              
  Lines      160260   160260              
  Branches    17259    17259              
==========================================
+ Hits       120369   120385      +16     
+ Misses      35070    35061       -9     
+ Partials     4821     4814       -7
Flag Coverage Δ
#Debug 75.11% <ø> (ø) ⬆️
#production 70.52% <ø> (+0.01%) ⬆️
#test 90.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
....ML.Data/DataLoadSave/LegacyCompositeDataLoader.cs 83.12% <ø> (ø) ⬆️
test/Microsoft.ML.Functional.Tests/ModelFiles.cs 96.26% <ø> (ø) ⬆️
...icrosoft.ML.Functional.Tests/DataTransformation.cs 100% <ø> (ø) ⬆️
...est/Microsoft.ML.Tests/Transformers/ConcatTests.cs 91.81% <ø> (ø) ⬆️
...L.AutoML/TrainerExtensions/TrainerExtensionUtil.cs 85.15% <0%> (-1.75%) ⬇️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 84.44% <0%> (-0.16%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 83.89% <0%> (+0.84%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 86.55% <0%> (+6.72%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100% <0%> (+20.51%) ⬆️

@sharwell sharwell merged commit be98634 into dotnet:master Dec 8, 2019
@sharwell sharwell deleted the static-local-function branch December 8, 2019 04:06
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants