Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Contributing: Fix typos #4633
Changing the name of the variable only in the places you did seems to not be enough, since all of the builds are failing with this error:
@MaherJendoubi did you try to build this in your machine before opening the PR? I would think that this would have to fail on your machine too. Please, try to fix this renaming and check if it builds in your machine before updating this PR. Thanks!
I think you're missing the one here:
And as @antoniovs1029 suggests, building locally will catch any missing renames. Since functionality isn't modified, I'm not expecting the unit tests to show anything interesting; though they're always nice to run, and further end-to-end testing of an AutoML pipeline can catch additional problems.
@MaherJendoubi . Unfortunately the builds are still failing, as you can see here:
The error is
So there are still places where variables need to be renamed.
Can you tell us what problem are you encountering when building ML.NET? I might be able to assist you so you can run things locally and make it easier for you to fix this problem. Thanks for your contributions!
You can also check on the errors in the CI tests. You can see a build error here:
Which ends with:
This error is pointing to this line:
Renaming within Visual Studio is easier as it generally finds all occurrences when renaming.
You can navigate to the build output by clicking on the warning/errors on Checks page (or by clicking the Details for the CI on this page):
@@ Coverage Diff @@ ## master #4633 +/- ## ========================================= Coverage ? 75.66% ========================================= Files ? 938 Lines ? 168766 Branches ? 18228 ========================================= Hits ? 127689 Misses ? 36047 Partials ? 5030