Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featurizers Nuget fix, DateTimeTransformer path fix #4639

Merged
merged 3 commits into from Jan 15, 2020

Conversation

@michaelgsharp
Copy link
Member

michaelgsharp commented Jan 9, 2020

Fix the nuget package to also add in netcoreapp2.1 as a target framework.

Nimbus ML moves the native code DLL from where it is restored to a different location. This was causing issues with finding the data files required for DateTimeTransformer to do holidays correctly. This change makes the DateTimeTransformer look in 2 places for the existence of the data files, the restore location and the current location of the .dll, resolving the issues.

@michaelgsharp michaelgsharp requested a review from dotnet/mlnet-core as a code owner Jan 9, 2020
@michaelgsharp michaelgsharp self-assigned this Jan 9, 2020
@michaelgsharp michaelgsharp requested a review from ganik Jan 9, 2020
@pieths
pieths approved these changes Jan 9, 2020
@ganik
ganik approved these changes Jan 15, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 15, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@0435f6b). Click here to learn what that means.
The diff coverage is 37.5%.

@@            Coverage Diff            @@
##             master    #4639   +/-   ##
=========================================
  Coverage          ?   75.85%           
=========================================
  Files             ?      947           
  Lines             ?   172184           
  Branches          ?    18578           
=========================================
  Hits              ?   130604           
  Misses            ?    36410           
  Partials          ?     5170
Flag Coverage Δ
#Debug 75.85% <37.5%> (?)
#production 71.44% <37.5%> (?)
#test 90.7% <ø> (?)
Impacted Files Coverage Δ
...rc/Microsoft.ML.Featurizers/DateTimeTransformer.cs 88.62% <37.5%> (ø)
@michaelgsharp michaelgsharp merged commit b045e4d into dotnet:master Jan 15, 2020
19 checks passed
19 checks passed
MachineLearning-CI Build #20200109.7 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CodeCoverage Build #20200109.7 had test failures
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.