Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc misspellings #4642

Merged
merged 14 commits into from Jan 13, 2020
Merged

Misc misspellings #4642

merged 14 commits into from Jan 13, 2020

Conversation

@MaherJendoubi
Copy link
Contributor

MaherJendoubi commented Jan 10, 2020

Fix issue #4638

Fixed a typo: LastOccurenceWins --> LastOccurrenceWins
accomodate --> accommodate
occured --> occurred
becuase  --> because
begining --> beginning
neccessary  --> necessary
publically  --> publicly
preceeding --> preceding
acheived  --> achieved
definitly  -->  definitely
realy   -->  really
seperate  --> separate
orignal  -->  original
diffrence  -->  difference
untill  -->  until
sucessfully  -->  successfully
@MaherJendoubi MaherJendoubi requested a review from dotnet/mlnet-core as a code owner Jan 10, 2020
@antoniovs1029

This comment has been minimized.

Copy link
Member

antoniovs1029 commented Jan 10, 2020

Hi, @MaherJendoubi , it seems all the pipelines are failing: https://github.com/dotnet/machinelearning/pull/4642/checks

I have just had a quick look at all of this, and now it isn't a build error (like in your previous PR), but actually some Tests related to Entry points are failing. I am not sure why would it be the case, since it seems to me you only renamed LastOccurenceWins in the ArgumentType enum and some comments.

I will rerun the tests on azure pipelines to see if there's any difference. And perhaps I will try to have a closer look later today. But in the meantime, it would also be great if you can investigate why the errors are occurring. Thanks for your collaboration!

mantains  --> maintains
entrypy  -->  entropy
@antoniovs1029

This comment has been minimized.

Copy link
Member

antoniovs1029 commented Jan 11, 2020

Hi @MaherJendoubi . It seems that the problem is that you also need to update these files fixing there the misspellings:

https://github.com/dotnet/machinelearning/blob/master/test/BaselineOutput/Common/EntryPoints/core_ep-list.tsv

https://github.com/dotnet/machinelearning/blob/master/test/BaselineOutput/Common/EntryPoints/core_manifest.json

If you fix them in those files, the pipelines should run correctly now.

Those files can be thought as containing the description of the different components that ML.NET exposes as entry points. In the Microsoft.ML.RunTests.TestEntryPoints.EntryPointCatalog test (which was the test where your PR was failing), a new updated temporal version of those files is created and compared to those files, if they are not the same, the test fails. This new temporal version was affected by some of your other changes... for example, your update to the GamTrainer Summary. The summary of the trainers is also included in those files, so when updating the summary in the code, those other files should also be updated.

So, in general, I think that fixing the misspellings in the 2 files I've linked to above should be enough ;)

This reverts commit 49e0abc.
@MaherJendoubi

This comment has been minimized.

Copy link
Contributor Author

MaherJendoubi commented Jan 11, 2020

Hi @antoniovs1029 Thanks a lot for the investigation! I fixed them but I still have 4 failing tests locally because my Windows 10 OS version is French:

  • [xUnit.net 00:00:03.62] Microsoft.ML.InternalCodeAnalyzer.Tests.BestFriendTest.BestFriend [FAIL]
    [xUnit.net 00:00:03.63] Microsoft.ML.InternalCodeAnalyzer.Tests.ContractsCheckTest.ContractsCheckFix [FAIL]
    X Microsoft.ML.InternalCodeAnalyzer.Tests.BestFriendTest.BestFriend [1s 992ms]
    Error Message:
    Context: Diagnostics of test state
    Expected diagnostic message to be "'D.D(float)' is inaccessible due to its protection level" was "'D.D(float)' est inaccessible en raison de son niveau de protection"

Diagnostic:
// Test0.cs(23,21): error CS0122: 'D.D(float)' est inaccessible en raison de son niveau de protection

  • Expected: True
    Actual: False
    Stack Trace:
    at Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier.Equal[T](T expected, T actual, String message) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Testing.Verifiers.XUnit/XUnitVerifier.cs:line 47
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest1.VerifyDiagnosticResults(IEnumerable1 actualResults, ImmutableArray1 analyzers, DiagnosticResult[] expectedResults, IVerifier verifier) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest1.cs:line 267
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest1.VerifyDiagnosticsAsync(ValueTuple2[] sources, ValueTuple2[] additionalFiles, MetadataReference[] additionalMetadataReferences, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest1.cs:line 151
    at Microsoft.CodeAnalysis.Testing.CodeFixTest1.RunAsync(CancellationToken cancellationToken) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest1.cs:line 182
    at Microsoft.ML.InternalCodeAnalyzer.Tests.BestFriendTest.BestFriend() in C:\Users\xxx\Documents\GitHub\machinelearning\test\Microsoft.ML.CodeAnalyzer.Tests\Code\BestFriendTest.cs:line 91
    --- End of stack trace from previous location where exception was thrown ---
    X Microsoft.ML.InternalCodeAnalyzer.Tests.ContractsCheckTest.ContractsCheckFix [2s 18ms]
    Error Message:
    Context: Diagnostics of test state
    Expected diagnostic message to be "'ICancelable' is inaccessible due to its protection level" was "'ICancelable' est inaccessible en raison de son niveau de protection"

Diagnostic:
// Test1.cs(752,24): error CS0122: 'ICancelable' est inaccessible en raison de son niveau de protection

  • Expected: True
    Actual: False
    Stack Trace:
    at Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier.Equal[T](T expected, T actual, String message) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Testing.Verifiers.XUnit/XUnitVerifier.cs:line 47
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest1.VerifyDiagnosticResults(IEnumerable1 actualResults, ImmutableArray1 analyzers, DiagnosticResult[] expectedResults, IVerifier verifier) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest1.cs:line 267
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest1.VerifyDiagnosticsAsync(ValueTuple2[] sources, ValueTuple2[] additionalFiles, MetadataReference[] additionalMetadataReferences, DiagnosticResult[] expected, IVerifier verifier, CancellationToken cancellationToken) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest1.cs:line 151
    at Microsoft.CodeAnalysis.Testing.CodeFixTest1.RunAsync(CancellationToken cancellationToken) in /_/src/Tools/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest1.cs:line 182
    at Microsoft.ML.InternalCodeAnalyzer.Tests.ContractsCheckTest.ContractsCheckFix() in C:\Users\xxx\Documents\GitHub\machinelearning\test\Microsoft.ML.CodeAnalyzer.Tests\Code\ContractsCheckTest.cs:line 158
    --- End of stack trace from previous location where exception was thrown ---
    [xUnit.net 00:00:03.74] Microsoft.ML.InternalCodeAnalyzer.Tests.ContractsCheckTest.ContractsCheck [FAIL]
    X Microsoft.ML.InternalCodeAnalyzer.Tests.ContractsCheckTest.ContractsCheck [132ms]
    Error Message:
    Context: Diagnostics of test state
    Expected diagnostic message to be "Inconsistent accessibility: parameter type 'IHostEnvironment' is less accessible than method 'TypeName.TypeName(IHostEnvironment, float, int)'" was "Accessibilité incohérente : le type de paramètre 'IHostEnvironment' est moins accessible que la méthode 'TypeName.TypeName(IHostEnvironment, float, int)'"

Diagnostic:
// Test0.cs(15,16): error CS0051: Accessibilité incohérente : le type de paramètre 'IHostEnvironment' est moins accessible que la méthode 'TypeName.TypeName(IHostEnvironment, float, int)'

  • [xUnit.net 00:00:02.31] Microsoft.ML.Tests.TimeSeries.SsaForecast [FAIL]
    X Microsoft.ML.Tests.TimeSeries.SsaForecast [46ms]
    Error Message:
    Assert.Equal() Failure
    Expected: 0,1914917 (rounded from 0,191491723060608)
    Actual: 6,9588203 (rounded from 6,95882034301758)

    Stack Trace:
    at Microsoft.ML.Tests.TimeSeries.SsaForecast() in C:\Users\xxx\Documents\GitHub\machinelearning\test\Microsoft.ML.TimeSeries.Tests\TimeSeriesDirectApi.cs:line 372
@antoniovs1029

This comment has been minimized.

Copy link
Member

antoniovs1029 commented Jan 13, 2020

Hi, @MaherJendoubi and thanks for your contributions!

I don't know why are your tests failing in your local machine, since all of the tests have already passed on the CI pipelines:
https://github.com/dotnet/machinelearning/pull/4642/checks

I've also ran the tests of your fork, locally in my Visual Studio, and they also pass without any problem.

Since all the tests have passed there, I will merge this PR :D Thanks again.

@antoniovs1029 antoniovs1029 merged commit 712c3ec into dotnet:master Jan 13, 2020
17 of 19 checks passed
17 of 19 checks passed
MachineLearning-CodeCoverage Build #20200111.13 had test failures
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug failed
Details
MachineLearning-CI Build #20200111.13 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@MaherJendoubi MaherJendoubi deleted the MaherJendoubi:misc-misspellings branch Jan 13, 2020
@MaherJendoubi

This comment has been minimized.

Copy link
Contributor Author

MaherJendoubi commented Jan 13, 2020

Hi @antoniovs1029,
You could easily reproduce my local errors by spinning up an Azure VM Windows 10 French OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.