Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormalizeMinMax Multicolumn example #4644

Open
wants to merge 3 commits into
base: master
from

Conversation

@jwood803
Copy link
Contributor

jwood803 commented Jan 11, 2020

Update for #3436 for the NormalizeMinMax transform.

@sfilipi Took a shot at adding a multicolumn sample. If this is on the right track, I can help with some of the others.

@jwood803 jwood803 requested a review from dotnet/mlnet-core as a code owner Jan 11, 2020
@antoniovs1029 antoniovs1029 requested a review from natke Jan 14, 2020
Copy link
Contributor

natke left a comment

I've added a few corrects and comments. Please feel free to reach out if anything is unclear

// 0.0000, 0.0000, 0.3333, 0.0000 0.6667, 1.0000, 1.0000
// -0.5000, -0.5000, -0.3333, 1.0000 1.0000, 0.0000, 0.5000

// Let's get transformation parameters. Since we work with only one

This comment has been minimized.

Copy link
@natke

natke Jan 14, 2020

Contributor

Since we work with only one -> Since there is only one

This comment has been minimized.

Copy link
@natke

natke Jan 14, 2020

Contributor

Don't we have two columns here? Features and Features2?

This comment has been minimized.

Copy link
@jwood803

jwood803 Jan 15, 2020

Author Contributor

Updated the wording of the comment, but I'll need to see how the formula changes since there are two columns instead of one.

Copy link
Contributor Author

jwood803 left a comment

@natke Thanks for the review! Made most of the changes, but I would need to update the last output for the formula since there are now two columns.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 15, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@0435f6b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4644   +/-   ##
=========================================
  Coverage          ?   75.84%           
=========================================
  Files             ?      947           
  Lines             ?   172170           
  Branches          ?    18576           
=========================================
  Hits              ?   130585           
  Misses            ?    36416           
  Partials          ?     5169
Flag Coverage Δ
#Debug 75.84% <ø> (?)
#production 71.43% <ø> (?)
#test 90.7% <ø> (?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.