Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xref formatting #4647

Merged
merged 2 commits into from Jan 13, 2020
Merged

Fixed xref formatting #4647

merged 2 commits into from Jan 13, 2020

Conversation

@mstfbl
Copy link
Member

mstfbl commented Jan 13, 2020

Fixes #4611

Updated cross-references of ML.Data.ExpressionTransformer and ML.Data.VectorDataViewType to the correct format.

AB#1667125

@mstfbl mstfbl requested a review from dotnet/mlnet-core Jan 13, 2020
Copy link
Member

sharwell left a comment

Hard tabs should be fixed back to spaces

@mstfbl mstfbl requested a review from sharwell Jan 13, 2020
Copy link
Member

sharwell left a comment

In both the current and new form, the documentation references are not recognized by the compiler, so they will not interact correctly with Find All References and other features. The suggested change updates these to follow the proper syntax.

src/Microsoft.ML.Transforms/ExpressionTransformer.cs Outdated Show resolved Hide resolved
src/Microsoft.ML.Transforms/ExpressionTransformer.cs Outdated Show resolved Hide resolved
@mstfbl

This comment has been minimized.

Copy link
Member Author

mstfbl commented Jan 13, 2020

@sharwell Silly Visual Studio setting, fixed, thanks!

@sharwell sharwell dismissed their stale review Jan 13, 2020

Blocking change to tabs has been addressed.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #4647 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4647      +/-   ##
==========================================
- Coverage   75.78%   75.77%   -0.01%     
==========================================
  Files         944      944              
  Lines      171156   171156              
  Branches    18468    18468              
==========================================
- Hits       129715   129699      -16     
- Misses      36316    36336      +20     
+ Partials     5125     5121       -4
Flag Coverage Δ
#Debug 75.77% <ø> (-0.01%) ⬇️
#production 71.36% <ø> (-0.02%) ⬇️
#test 90.65% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...c/Microsoft.ML.Transforms/ExpressionTransformer.cs 96.07% <ø> (ø) ⬆️
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0%> (-6.99%) ⬇️
...icrosoft.ML.AutoML/Experiment/SuggestedPipeline.cs 88.65% <0%> (-4.13%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 86.55% <0%> (-0.85%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 85.11% <0%> (-0.21%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.1% <0%> (-0.16%) ⬇️
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 85.03% <0%> (-0.16%) ⬇️
test/Microsoft.ML.AutoML.Tests/DatasetUtil.cs 91.07% <0%> (+2.67%) ⬆️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 100% <0%> (+20.51%) ⬆️
@mstfbl mstfbl merged commit c3335b6 into dotnet:master Jan 13, 2020
19 checks passed
19 checks passed
MachineLearning-CI Build #20200113.3 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CodeCoverage Build #20200113.3 succeeded
Details
MachineLearning-CodeCoverage (Windows_x64 Build_Debug) Windows_x64 Build_Debug succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.