Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Changed Binarizer node to be cast to the type of the predicted label … #4818
…column's data type
In BinaryClassifierScorer's SaveAsOnnxCore function we were always casting the output of the Binarizer to a bool. But in some cases BinaryClassifierScorer can output a key value (uint) and in this case we should cast the output to a uint. This fix changes the cast to be dependent on the output type of the predicted label.
I know this isn't related to the change in this PR, but is this correct? The binary classifier scorer has a
While I could not find a way in the public API to change which column is used (by default it is actually the score column, even if the probability column exists), there is a public API to change the threshold value:
Yep, this is not correct. Predicted label has to be based off threshold.
In reply to: 584023200 (ancestors = 584023200)