Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OnnxTransformer to accept KeyDataViewTypes as if they were UInt32 #4824

Merged
merged 8 commits into from Feb 12, 2020

Conversation

@antoniovs1029
Copy link
Member

antoniovs1029 commented Feb 11, 2020

Addresses microsoft/NimbusML#426

As discussed offline with @harishsk , @ganik and @pieths , the update in here is the best temporary solution to the problem.

Simply enables OnnxTransformer to accept a KeyDataViewType column as input of a model that actually expects an UInt32 input column. This, because of the way that NimbusML works with Category columns in Pandas' DataFrames, by converting them into KeyDataViewType columns in ML.NET, without actually adding KeyToValueTransformers into the pipeline.

@antoniovs1029 antoniovs1029 requested a review from dotnet/mlnet-core as a code owner Feb 11, 2020
Copy link
Member

harishsk left a comment

Can you please add a test and also a comment in the code describing the scenario this is necessary for?

@antoniovs1029

This comment has been minimized.

Copy link
Member Author

antoniovs1029 commented Feb 11, 2020

/azp run

@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Feb 11, 2020

Azure Pipelines successfully started running 1 pipeline(s).
Copy link
Member

harishsk left a comment

:shipit:

@ganik
ganik approved these changes Feb 11, 2020
Copy link
Member

ganik left a comment

:shipit:

@ganik ganik merged commit 528435c into dotnet:master Feb 12, 2020
17 checks passed
17 checks passed
MachineLearning-CI Build #20200211.16 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.