Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off by 1 error with the cats_int64s attribute for the OneHotEncoder ONNX operator #4827

Merged
merged 2 commits into from Feb 12, 2020

Conversation

@pieths
Copy link
Contributor

pieths commented Feb 11, 2020

No description provided.

…er ONNX operator.
@pieths pieths requested a review from dotnet/mlnet-core as a code owner Feb 11, 2020
Copy link
Member

harishsk left a comment

:shipit:

@ganik
ganik approved these changes Feb 11, 2020
Copy link
Member

ganik left a comment

:shipit:

Copy link
Member

harishsk left a comment

It is a good idea to run all the tests in OnnxConversionTest.cs to verify if this change is breaking something else.

@pieths

This comment has been minimized.

Copy link
Contributor Author

pieths commented Feb 12, 2020

I just ran those tests and added two more off by 1 fixes for the unit tests. The changes have been added to the pull request.

@pieths

This comment has been minimized.

Copy link
Contributor Author

pieths commented Feb 12, 2020

/azp run

@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Feb 12, 2020

Commenter does not have sufficient privileges for PR 4827 in repo dotnet/machinelearning
@harishsk harishsk merged commit d2d90d6 into dotnet:master Feb 12, 2020
17 checks passed
17 checks passed
MachineLearning-CI Build #20200211.14 had test failures
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@pieths pieths deleted the pieths:onehot_onnx_fix branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.