Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixing TextNormalizing test issue with Linux machines #4834

Open
wants to merge 6 commits into
base: master
from

Conversation

@Lynx1820
Copy link
Member

Lynx1820 commented Feb 13, 2020

No description provided.

@Lynx1820 Lynx1820 requested a review from dotnet/mlnet-core as a code owner Feb 13, 2020
@@ -49,6 +49,7 @@ jobs:
- script: brew update && brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/f5b1ac99a7fba27c19cee0bc4f036775c889b359/Formula/libomp.rb && brew unlink python@2 && brew install mono-libgdiplus gettext && brew link gettext --force && brew link libomp --force
displayName: Install build dependencies
- ${{ if and( eq(parameters.nightlyBuild, 'true'), eq(parameters.name, 'Ubuntu_x64_NetCoreApp21')) }}:
- script: sudo locale-gen en_US.UTF-8 && sudo update-locale

This comment has been minimized.

Copy link
@harishsk

harishsk Feb 13, 2020

Member

Will the sudo commands succeed on the server? I am curious to find out.

This comment has been minimized.

Copy link
@frank-dong-ms

frank-dong-ms Feb 13, 2020

Member

Seems not:

/__w/_temp/1707e74d-1295-4ff9-815a-b62ba21f6a2a.sh: line 1: sudo: command not found


In reply to: 379053227 [](ancestors = 379053227)

@@ -49,6 +49,7 @@ jobs:
- script: brew update && brew install https://raw.githubusercontent.com/Homebrew/homebrew-core/f5b1ac99a7fba27c19cee0bc4f036775c889b359/Formula/libomp.rb && brew unlink python@2 && brew install mono-libgdiplus gettext && brew link gettext --force && brew link libomp --force
displayName: Install build dependencies
- ${{ if and( eq(parameters.nightlyBuild, 'true'), eq(parameters.name, 'Ubuntu_x64_NetCoreApp21')) }}:
- script: sudo locale-gen en_US.UTF-8 && sudo update-locale

This comment has been minimized.

Copy link
@frank-dong-ms

frank-dong-ms Feb 13, 2020

Member

This is place for nightly build only.

Use below as separate step:

  • ${{ if eq(parameters.name, 'Ubuntu_x64_NetCoreApp21') }}:
    - script: sudo locale-gen en_US.UTF-8 && sudo update-locale
    displayName: Install and Update locale
Lynx1820 added 2 commits Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.