Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MSML_PrivateFieldName for the full solution #4835

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@sharwell
Copy link
Member

sharwell commented Feb 13, 2020

No description provided.

@sharwell sharwell requested review from dotnet/mlnet-automl as code owners Feb 13, 2020
@sharwell sharwell force-pushed the sharwell:code-style branch from 02f60a6 to a601c6d Feb 13, 2020
@sharwell sharwell force-pushed the sharwell:code-style branch from a601c6d to 965616c Feb 13, 2020
@justinormont

This comment was marked as resolved.

Copy link
Member

justinormont commented Feb 13, 2020

LGTM, and there's a few more to fix hiding behind preprocessor directives:

#if NETCOREAPP3_0
private static Dictionary<string, string> DisableAvxEnvironmentVariables;
private static Dictionary<string, string> DisableAvxAndSseEnvironmentVariables;
private static readonly string disableAvx = "COMPlus_EnableAVX";
private static readonly string disableSse = "COMPlus_EnableSSE";
private static readonly string disableAvxAndSse = "COMPlus_EnableHWIntrinsic";
#endif

@sharwell

This comment has been minimized.

Copy link
Member Author

sharwell commented Feb 13, 2020

@justinormont Already resolved 👍

Copy link
Member

frank-dong-ms left a comment

:shipit:

@sharwell sharwell merged commit 449719c into dotnet:master Feb 13, 2020
17 checks passed
17 checks passed
MachineLearning-CI Build #20200213.16 succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Debug_Build) Centos_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp30 Release_Build) Centos_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Debug_Build) Windows_x64_NetCoreApp30 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp30 Release_Build) Windows_x64_NetCoreApp30 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@sharwell sharwell deleted the sharwell:code-style branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.