Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated build docs for .NET Core 3.1 #4967

Merged
merged 3 commits into from Mar 24, 2020
Merged

Conversation

@mstfbl
Copy link
Member

mstfbl commented Mar 24, 2020

Updated Windows and Unix build docs for .NET Core 3.1.

Some specific things to note:

  • In addition to other platforms, .NET Core 3.1 supports Ubuntu 16.04+ and macOS 10.13 (High Sierra)
  • [Visual Studio 2019 Version 16.4 or higher is needed for .NET Core 3.1.
  • /src files always build on both netstandard2.0 and netcoreapp3.1, and /tests only build on one target framework at a time: netcoreapp2.1, net461 or netcoreapp3.1
@mstfbl mstfbl requested a review from harishsk Mar 24, 2020
@mstfbl mstfbl requested a review from dotnet/mlnet-core as a code owner Mar 24, 2020
@@ -1,4 +1,4 @@
ML.NET now builds for .NET Core 3.0 by default. However to run tests on .NET Core 3.0, you need to do a few manual steps.
ML.NET now builds for .NET Core 3.1 by default. However to run tests on .NET Core 3.1, you need to do a few manual steps.

This comment has been minimized.

Copy link
@harishsk

harishsk Mar 24, 2020

Member

Is this accurate? I think we build for netcoreapp21 when you run build. #Resolved

This comment has been minimized.

Copy link
@mstfbl

mstfbl Mar 24, 2020

Author Member

The src files always build on both netstandard2.0 and netcoreapp3.1. Meanwhile the tests only build on one target framework at a time: netcoreapp2.1, net461 or netcoreapp3.1 (Thanks @eerhardt !) I updated this document to reflect this. #Resolved

@mstfbl mstfbl merged commit 329817a into dotnet:master Mar 24, 2020
17 checks passed
17 checks passed
MachineLearning-CI Build #20200324.23 succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp31 Debug_Build) Centos_x64_NetCoreApp31 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp31 Release_Build) Centos_x64_NetCoreApp31 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp31 Debug_Build) Windows_x64_NetCoreApp31 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp31 Release_Build) Windows_x64_NetCoreApp31 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.