Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade benchmark dotnet package to latest version #4968

Merged
merged 3 commits into from Mar 25, 2020

Conversation

@frank-dong-ms
Copy link
Member

frank-dong-ms commented Mar 24, 2020

As we have upgrade CI run from netcore 3.0 to netcore 3.1, we need also to upgrade benchmark dotnet to latest version which has netcore 3.1 support

@frank-dong-ms frank-dong-ms requested a review from dotnet/mlnet-core as a code owner Mar 24, 2020
@frank-dong-ms frank-dong-ms requested review from adamsitnik, harishsk and mstfbl Mar 24, 2020
Copy link
Member

adamsitnik left a comment

LGTM, thank you @frank-dong-ms !

@@ -11,7 +11,7 @@

namespace micro
{
[CoreJob]
[SimpleJob]

This comment has been minimized.

Copy link
@adamsitnik

adamsitnik Mar 25, 2020

Member

what is the purpose of this attribute? So far it was set to run only on .NET Core. If we don't want to run it only for .NET Core, we can just remove the attribute. #Resolved

This comment has been minimized.

Copy link
@frank-dong-ms

frank-dong-ms Mar 25, 2020

Author Member

yes, as far as I know benchmark only runs on dotnet core


In reply to: 397732628 [](ancestors = 397732628)

@frank-dong-ms frank-dong-ms merged commit 21d5680 into dotnet:master Mar 25, 2020
17 checks passed
17 checks passed
MachineLearning-CI Build #20200324.31 succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp31 Debug_Build) Centos_x64_NetCoreApp31 Debug_Build succeeded
Details
MachineLearning-CI (Centos_x64_NetCoreApp31 Release_Build) Centos_x64_NetCoreApp31 Release_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Debug_Build) MacOS_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (MacOS_x64_NetCoreApp21 Release_Build) MacOS_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Debug_Build) Ubuntu_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Ubuntu_x64_NetCoreApp21 Release_Build) Ubuntu_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Debug_Build) Windows_x64_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp21 Release_Build) Windows_x64_NetCoreApp21 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp31 Debug_Build) Windows_x64_NetCoreApp31 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetCoreApp31 Release_Build) Windows_x64_NetCoreApp31 Release_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Debug_Build) Windows_x64_NetFx461 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x64_NetFx461 Release_Build) Windows_x64_NetFx461 Release_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Debug_Build) Windows_x86_NetCoreApp21 Debug_Build succeeded
Details
MachineLearning-CI (Windows_x86_NetCoreApp21 Release_Build) Windows_x86_NetCoreApp21 Release_Build succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.