Skip to content

Conversation

@LittleLittleCloud
Copy link
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

This PR implements SweepablePipeline according to spec in #6218

The new SweepablePipeline will replace MultiModelPipeline and SweepableEstimatorPipeline and would be helpful in constructing complex sweepable pipeline as well as facilitating future optimization over sweeping method

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #6222 (bda4fcd) into main (4715e61) will increase coverage by 0.03%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##             main    #6222      +/-   ##
==========================================
+ Coverage   68.43%   68.46%   +0.03%     
==========================================
  Files        1139     1140       +1     
  Lines      244596   244801     +205     
  Branches    25390    25435      +45     
==========================================
+ Hits       167384   167602     +218     
+ Misses      70577    70563      -14     
- Partials     6635     6636       +1     
Flag Coverage Δ
Debug 68.46% <87.87%> (+0.03%) ⬆️
production 62.93% <ø> (+0.04%) ⬆️
test 89.01% <87.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icrosoft.ML.AutoML.Tests/SweepablePipelineTests.cs 87.87% <87.87%> (ø)
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.77% <0.00%> (-0.48%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.38% <0.00%> (-0.15%) ⬇️
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 89.04% <0.00%> (ø)
src/Microsoft.ML.TorchSharp/TorchSharpCatalog.cs 100.00% <0.00%> (ø)
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.82% <0.00%> (ø)
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (+1.01%) ⬆️
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 92.32% <0.00%> (+1.24%) ⬆️
src/Microsoft.ML.FastTree/Training/StepSearch.cs 62.37% <0.00%> (+4.95%) ⬆️
... and 1 more

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).


public override IEstimator<ITransformer> BuildFromOption(MLContext context, Parameter param)
{
this.Parameter = param;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid this when possible.

Copy link
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelgsharp michaelgsharp merged commit 7ae1c5d into dotnet:main Jun 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants