Skip to content

Conversation

@michaelgsharp
Copy link
Contributor

Fixes native lookup with adds a bunch more testing for M1 and normal mac as well.

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (5b4981a) to head (96d6456).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs 0.00% 3 Missing and 1 partial ⚠️
...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs 62.50% 1 Missing and 2 partials ⚠️
...Common/Attributes/NativeDependencyFactAttribute.cs 0.00% 1 Missing and 1 partial ⚠️
...mmon/Attributes/NativeDependencyTheoryAttribute.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7282      +/-   ##
==========================================
- Coverage   68.87%   68.84%   -0.04%     
==========================================
  Files        1467     1473       +6     
  Lines      273954   274173     +219     
  Branches    28380    28424      +44     
==========================================
+ Hits       188693   188744      +51     
- Misses      77952    78114     +162     
- Partials     7309     7315       +6     
Flag Coverage Δ
Debug 68.84% <31.25%> (-0.04%) ⬇️
production 63.29% <ø> (-0.05%) ⬇️
test 89.16% <31.25%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Common/Attributes/NativeDependencyFactAttribute.cs 77.77% <0.00%> (-22.23%) ⬇️
...mmon/Attributes/NativeDependencyTheoryAttribute.cs 77.77% <0.00%> (-22.23%) ⬇️
...ft.ML.TestFrameworkCommon/Utility/NativeLibrary.cs 52.94% <62.50%> (+1.32%) ⬆️
...oft.ML.TestFrameworkCommon/Utility/PathResolver.cs 64.28% <0.00%> (-3.22%) ⬇️

... and 28 files with indirect coverage changes

@michaelgsharp
Copy link
Contributor Author

Merging on red since the only test failures are known test failures and we don't have the repo set up correctly for Build Analysis to be able to bypass it.

@michaelgsharp michaelgsharp merged commit e968d32 into dotnet:main Nov 11, 2024
22 of 25 checks passed
@michaelgsharp
Copy link
Contributor Author

/backport to release/4.0

@github-actions
Copy link
Contributor

Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/11787367067

@michaelgsharp michaelgsharp deleted the apple-silicon branch November 11, 2024 23:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant