Skip to content

Conversation

@artidoro
Copy link
Contributor

Fixes #697

  • I added the attribution for the images located in the test/data/images folder.
  • I used the citation format indicated in wikipedia's "best practices for attributions"

Note: I used the same readme that provides citations for the datasets located in test/data and separated it in two parts. I think it makes more sense to keep the citations for the data and images in the folder in a single file.

@dnfclas
Copy link

dnfclas commented Aug 30, 2018

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka
Copy link
Contributor

Unfortunately one of builds failed, and we currently don't have infrastructure to restart build (We can queue another one, but it wouldn't be picked up by git). So only way to retrigger build is to push another change.

@codemzs
Copy link
Member

codemzs commented Aug 30, 2018

That or just modifying the commit message will also retrigger the build
git commit --amend -m "Just to trigger the build"
git push --force


In reply to: 417383501 [](ancestors = 417383501)

@artidoro
Copy link
Contributor Author

Ok will amend the commit then! Thank you

Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@artidoro artidoro merged commit 804a6d0 into dotnet:master Aug 30, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants