Skip to content

Fix typo in src/Simd/README.md: "43-bit" → "32-bit" for NVector3i#25334

Merged
rolfbjarne merged 1 commit into
mainfrom
op-fix-simd-readme-43bit-typo
May 6, 2026
Merged

Fix typo in src/Simd/README.md: "43-bit" → "32-bit" for NVector3i#25334
rolfbjarne merged 1 commit into
mainfrom
op-fix-simd-readme-43bit-typo

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Line 156 of src/Simd/README.md described NVector3i as "A vector of 3 43-bit ints.", which is a factual error.

NVector3i wraps the native simd_int3 / vector_int3 type, which is a vector of three 32-bit signed integers. The sibling types NVector2i and NVector4i already correctly say "32-bit" in the same file.

Change: 43-bit32-bit on line 156 — documentation only, no code changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 14:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a factual typo in the SIMD documentation for CoreGraphics.NVector3i, aligning it with the underlying native type (simd_int3 / vector_int3) and the sibling NVector2i/NVector4i entries.

Changes:

  • Correct NVector3i description from “43-bit” to “32-bit” integers in src/Simd/README.md.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build #6303ba9] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 6303ba96a7306b8adab5c075f17544a3c852856a [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #6303ba9] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 6303ba96a7306b8adab5c075f17544a3c852856a [PR build]

@rolfbjarne rolfbjarne enabled auto-merge (squash) May 5, 2026 15:05
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6303ba96a7306b8adab5c075f17544a3c852856a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [CI Build #6303ba9] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 6303ba96a7306b8adab5c075f17544a3c852856a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #6303ba9] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 6303ba96a7306b8adab5c075f17544a3c852856a [PR build]

@rolfbjarne rolfbjarne merged commit 4ca4441 into main May 6, 2026
58 checks passed
@rolfbjarne rolfbjarne deleted the op-fix-simd-readme-43bit-typo branch May 6, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants