[tools] Use instance-based Log methods. by rolfbjarne · Pull Request #25566 · dotnet/macios

rolfbjarne · 2026-05-28T13:26:48Z

This will become important soon, because much of the code here will run from
inside an MSBuild task, and we mustn't call Console.[Error.]WriteLine from
inside an MSBuild task (it can cause tasks to deadlock). With these changes
it'll be much easier to remap Log calls to MSBuild's Task.LogMessage method.

This will become important soon, because much of the code here will run from inside an MSBuild task, and we mustn't call Console.[Error.]WriteLine from inside an MSBuild task (it can cause tasks to deadlock). With these changes it'll be much easier to remap Log calls to MSBuild's Task.LogMessage method.

Copilot

Pull request overview

This PR refactors tool logging from static Driver/console-based calls to instance-based IToolLog plumbing, preparing shared tooling code to run safely inside MSBuild tasks without direct console writes.

Changes:

Introduces IToolLog and implements it for tool applications, bgen, console logging, and MSBuild tasks.
Threads logging instances through shared helpers such as Driver, ErrorHelper, FileCopier, cache, resolver, Mach-O, and linker steps.
Updates MSBuild task verbosity and file-copy integration to use the new logging abstraction.

Reviewed changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tools/mtouch/mtouch.csproj	Links the shared logging abstraction into mtouch.
tools/mtouch/AssemblyResolver.cs	Threads `Application` logging into assembly resolution.
tools/linker/RegistrarRemovalTrackingStep.cs	Uses application-scoped logging/warnings.
tools/linker/MonoTouch.Tuner/ListExportedSymbols.cs	Replaces static logging with linker context app logging.
tools/linker/CoreOptimizeGeneratedCode.cs	Threads logging through optimization helpers and warnings.
tools/dotnet-linker/Steps/ManagedRegistrarStep.cs	Passes app logger to error reporting.
tools/dotnet-linker/Steps/ManagedRegistrarLookupTablesStep.cs	Uses app logging for diagnostic messages.
tools/dotnet-linker/Steps/InlineDlfcnMethodsStep.cs	Uses app logging for inlining diagnostics.
tools/dotnet-linker/Steps/InlineClassGetHandleStep.cs	Uses app logging and instance-based file writes.
tools/dotnet-linker/Steps/ExceptionalMarkHandler.cs	Exposes `Application` to derived handlers.
tools/dotnet-linker/PreserveSmartEnumConversionsStep.cs	Adds app logging for smart enum diagnostics.
tools/dotnet-linker/LinkerConfiguration.cs	Moves linker verbosity/log output to `Application`/`IToolLog`.
tools/dotnet-linker/DotNetResolver.cs	Adds constructor shape for app-aware resolver creation.
tools/dotnet-linker/dotnet-linker.csproj	Links the shared logging abstraction into dotnet-linker.
tools/dotnet-linker/BackingFieldDelayHandler.cs	Passes app logger into validation helpers.
tools/common/Target.cs	Threads logging through realpath, file writes, and generated main verbosity.
tools/common/StaticRegistrar.cs	Updates registrar logging/error reporting to use `App`.
tools/common/PInvokeWrapperGenerator.cs	Uses instance-aware file writing.
tools/common/MachO.cs	Replaces console diagnostics with `IToolLog`.
tools/common/IToolLog.cs	Adds the shared logging interface, extensions, and console implementation.
tools/common/Frameworks.cs	Uses app logging for framework filtering diagnostics.
tools/common/FileCopier.cs	Reworks copy/update logging and callbacks around `IToolLog`.
tools/common/ErrorHelper.tools.cs	Makes warning/error display logger-aware.
tools/common/Driver.execution.cs	Makes command execution logger-aware.
tools/common/Driver.cs	Removes static verbosity/log helpers and threads `IToolLog`.
tools/common/CoreResolver.cs	Threads logging through resolver load/search warnings.
tools/common/cache.cs	Makes cache location/comparison logging instance-aware.
tools/common/Assembly.cs	Uses application logging/cache APIs throughout assembly processing.
tools/common/Application.cs	Implements `IToolLog` and initializes app-scoped resolver/verbosity.
src/ObjCRuntime/Registrar.cs	Updates registrar warning dispatch/signatures.
src/ObjCRuntime/DynamicRegistrar.cs	Updates override signature for nullable args.
src/bgen/BindingTouch.cs	Implements `IToolLog` for bgen and uses instance verbosity.
src/bgen/bgen.csproj	Includes the shared logging abstraction in bgen.
msbuild/Xamarin.MacDev.Tasks/Xamarin.MacDev.Tasks.csproj	Links the shared logging abstraction into MSBuild tasks.
msbuild/Xamarin.MacDev.Tasks/VerbosityUtils.cs	Converts verbosity rendering/parsing to integer levels.
msbuild/Xamarin.MacDev.Tasks/Tasks/XamarinTask.cs	Implements `IToolLog` for MSBuild tasks.
msbuild/Xamarin.MacDev.Tasks/Tasks/ParseBundlerArguments.cs	Hides base verbosity for existing output property.
msbuild/Xamarin.MacDev.Tasks/Tasks/MergeAppBundles.cs	Uses task logging with `FileCopier`.
msbuild/Xamarin.MacDev.Tasks/Tasks/CreateBindingResourcePackage.cs	Uses task logging with `FileCopier`.
msbuild/Xamarin.MacDev.Tasks/Tasks/BGen.cs	Renders verbosity through the new helper.
msbuild/Xamarin.MacDev.Tasks/Decompress.cs	Uses task logging with `FileCopier` up-to-date checks.

…tatic-state-log

rolfbjarne · 2026-05-29T06:29:55Z

/azp run

azure-pipelines · 2026-05-29T06:30:25Z

Azure Pipelines successfully started running 3 pipeline(s).

rolfbjarne · 2026-06-02T06:01:33Z

/azp run

azure-pipelines · 2026-06-02T06:01:39Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

rolfbjarne · 2026-06-02T10:19:16Z

/azp run

azure-pipelines · 2026-06-02T10:19:46Z

Azure Pipelines successfully started running 3 pipeline(s).

…tatic-state-log

rolfbjarne · 2026-06-02T12:45:31Z

/azp run

azure-pipelines · 2026-06-02T12:46:02Z

Azure Pipelines successfully started running 3 pipeline(s).

vs-mobiletools-engineering-service2 · 2026-06-02T13:00:37Z

✅ [PR Build #5dac028] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 5dac0288166f37a84b73a30ce7732bff4a4446e4 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-02T13:03:44Z

✅ [PR Build #5dac028] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 5dac0288166f37a84b73a30ce7732bff4a4446e4 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-02T13:12:19Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5dac0288166f37a84b73a30ce7732bff4a4446e4 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-02T13:19:58Z

✅ [PR Build #5dac028] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 5dac0288166f37a84b73a30ce7732bff4a4446e4 [PR build]

vs-mobiletools-engineering-service2 · 2026-06-02T14:55:17Z

🚀 [CI Build #5dac028] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 193 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 5dac0288166f37a84b73a30ce7732bff4a4446e4 [PR build]

rolfbjarne requested a review from Copilot May 28, 2026 13:26

rolfbjarne added the copilot label May 28, 2026

Copilot started reviewing on behalf of rolfbjarne May 28, 2026 13:27 View session

fix

4088dc9

Copilot AI reviewed May 28, 2026

View reviewed changes

Comment thread msbuild/Xamarin.MacDev.Tasks/Tasks/BGen.cs

Auto-format source code

08c119c

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits May 28, 2026 19:28

Rename this one

3bf1706

Merge remote-tracking branch 'origin/main' into dev/rolf/tools-less-s…

598af78

…tatic-state-log

rolfbjarne marked this pull request as ready for review May 28, 2026 17:36

rolfbjarne requested a review from mauroa as a code owner May 28, 2026 17:36

dalexsoto approved these changes May 29, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

mauroa approved these changes May 29, 2026

View reviewed changes

rolfbjarne enabled auto-merge (squash) June 1, 2026 06:50

Update tests.

8232eba

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits June 2, 2026 14:44

Fix test build.

e202f44

Merge remote-tracking branch 'origin/main' into dev/rolf/tools-less-s…

5dac028

…tatic-state-log

This comment has been minimized.

Sign in to view

rolfbjarne merged commit a6b6c3c into main Jun 2, 2026
55 checks passed

Conversation

rolfbjarne commented May 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented May 29, 2026

Uh oh!

azure-pipelines Bot commented May 29, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

rolfbjarne commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 2, 2026

✅ [PR Build #5dac028] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 2, 2026

✅ [PR Build #5dac028] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 2, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 2, 2026

✅ [PR Build #5dac028] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 2, 2026

🚀 [CI Build #5dac028] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone