Skip to content

[github] Disable signed-commit replay in Code Radiator merge PR pushes#25577

Merged
rolfbjarne merged 3 commits into
mainfrom
copilot/xcode265
Jun 3, 2026
Merged

[github] Disable signed-commit replay in Code Radiator merge PR pushes#25577
rolfbjarne merged 3 commits into
mainfrom
copilot/xcode265

Conversation

Copilot AI commented May 29, 2026

Copy link
Copy Markdown
Contributor

Code Radiator failed to create the main -> xcode26.5 merge PR because safe-outputs attempted signed commit replay, then refused unsigned fallback when a submodule update was present. This change switches the merge workflow to explicit unsigned push behavior for PR branch updates.

  • Root cause addressed

    • Configure safe-outputs PR write paths to avoid pushSignedCommits replay for merge branches that can include unsupported commit shapes (notably submodule bumps).
  • Workflow source updates (code-radiator.md)

    • Set signed-commits: false under:
      • safe-outputs.create-pull-request
      • safe-outputs.push-to-pull-request-branch
  • Compiled workflow parity (code-radiator.lock.yml)

    • Updated generated safe-outputs handler/config payloads to include:
      • "signed_commits": false for create_pull_request
      • "signed_commits": false for push_to_pull_request_branch
safe-outputs:
  create-pull-request:
    max: 10
    signed-commits: false
  push-to-pull-request-branch:
    max: 10
    signed-commits: false

Copilot AI linked an issue May 29, 2026 that may be closed by this pull request
Co-authored-by: rolfbjarne <249268+rolfbjarne@users.noreply.github.com>
Copilot AI changed the title [WIP] Merge main into xcode26.5 Disable signed-commit replay in Code Radiator merge PR pushes May 29, 2026
Copilot AI requested a review from rolfbjarne May 29, 2026 07:09
@rolfbjarne rolfbjarne marked this pull request as ready for review May 29, 2026 09:48
Copilot AI review requested due to automatic review settings May 29, 2026 09:48
@rolfbjarne rolfbjarne enabled auto-merge (squash) May 29, 2026 09:48
@rolfbjarne rolfbjarne changed the title Disable signed-commit replay in Code Radiator merge PR pushes [github] Disable signed-commit replay in Code Radiator merge PR pushes May 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables signed-commit replay in the Code Radiator agentic workflow's safe-outputs so that merge PR branch pushes (which may include submodule bumps) no longer fail when the signed-commit path cannot handle the commit shape.

Changes:

  • Add signed-commits: false to safe-outputs.create-pull-request and safe-outputs.push-to-pull-request-branch in the workflow source.
  • Regenerate the compiled lock file so both the safe outputs config JSON and the handler config env var include "signed_commits": false for those two outputs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/code-radiator.md Adds signed-commits: false to the two PR-writing safe outputs.
.github/workflows/code-radiator.lock.yml Regenerated lock with matching "signed_commits": false in config JSON and handler env.

@rolfbjarne rolfbjarne disabled auto-merge June 1, 2026 06:53
@rolfbjarne rolfbjarne enabled auto-merge (squash) June 1, 2026 06:53
@rolfbjarne

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@rolfbjarne

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@rolfbjarne rolfbjarne merged commit 621547e into main Jun 3, 2026
11 checks passed
@rolfbjarne rolfbjarne deleted the copilot/xcode265 branch June 3, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🤖 Merge 'main' => 'xcode26.5' 🤖 Merge 'main' => 'xcode26.5' 🤖 Merge 'main' => 'xcode26.5' 🤖 Merge 'main' => 'xcode26.5'

4 participants