[tests] Filter out any warnings about using deprecated locations for the Xcode location.#25628
Conversation
…the Xcode location. These warnings are just noise for us at this point. Eventually we'll just stop using the deprecated locations.
There was a problem hiding this comment.
Pull request overview
This PR reduces test noise by centralizing and expanding warning filtering in the dotnet unit tests, specifically to ignore warnings about deprecated ways of selecting the Xcode location (and also consolidating existing “Supported iPhone orientations…” filtering).
Changes:
- Introduces
Extensions.FilterWarnings(...)/Extensions.IsFilteredWarning(...)to share warning filtering logic across tests. - Updates multiple unit tests to call the shared filter helper instead of duplicating
Where(...)filters. - Updates
BundleStructureTest.FilterWarnings(...)/ callers to passApplePlatformso platform-specific filters can be applied.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/dotnet/UnitTests/WindowsTest.cs | Updates BundleStructure warning filtering calls to pass platform into the updated helper. |
| tests/dotnet/UnitTests/TrimmerWarningsTest.cs | Replaces inline warning Where(...) with the shared .FilterWarnings(platform) helper. |
| tests/dotnet/UnitTests/ProjectTest.cs | Replaces repeated inline warning filters / predicates with the shared filtering helper. |
| tests/dotnet/UnitTests/ExtensionsTest.cs | Uses the shared warning filtering helper instead of a bespoke message check. |
| tests/dotnet/UnitTests/Extensions.cs | Adds the shared filtering implementation (including Xcode-location deprecation warning filters). |
| tests/dotnet/UnitTests/BundleStructureTest.cs | Threads platform through FilterWarnings(...) and delegates common filtering to Extensions.FilterWarnings(...). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
✅ [PR Build #a8d91e4] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #a8d91e4] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #a8d91e4] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #a8d91e4] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 2 tests failed, 171 tests passed. Failures❌ introspection tests1 tests failed, 5 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS)1 tests failed, 22 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found). Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
|
The test failures are unrelated. |
These warnings are just noise for us at this point. Eventually we'll just stop using the deprecated locations.