Skip to content

[tests] Filter out any warnings about using deprecated locations for the Xcode location.#25628

Merged
rolfbjarne merged 4 commits into
mainfrom
dev/rolf/tests-xcodelocation-warnings
Jun 4, 2026
Merged

[tests] Filter out any warnings about using deprecated locations for the Xcode location.#25628
rolfbjarne merged 4 commits into
mainfrom
dev/rolf/tests-xcodelocation-warnings

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

These warnings are just noise for us at this point. Eventually we'll just stop using the deprecated locations.

…the Xcode location.

These warnings are just noise for us at this point. Eventually we'll just stop using the deprecated locations.
Copilot AI review requested due to automatic review settings June 3, 2026 10:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces test noise by centralizing and expanding warning filtering in the dotnet unit tests, specifically to ignore warnings about deprecated ways of selecting the Xcode location (and also consolidating existing “Supported iPhone orientations…” filtering).

Changes:

  • Introduces Extensions.FilterWarnings(...) / Extensions.IsFilteredWarning(...) to share warning filtering logic across tests.
  • Updates multiple unit tests to call the shared filter helper instead of duplicating Where(...) filters.
  • Updates BundleStructureTest.FilterWarnings(...) / callers to pass ApplePlatform so platform-specific filters can be applied.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/dotnet/UnitTests/WindowsTest.cs Updates BundleStructure warning filtering calls to pass platform into the updated helper.
tests/dotnet/UnitTests/TrimmerWarningsTest.cs Replaces inline warning Where(...) with the shared .FilterWarnings(platform) helper.
tests/dotnet/UnitTests/ProjectTest.cs Replaces repeated inline warning filters / predicates with the shared filtering helper.
tests/dotnet/UnitTests/ExtensionsTest.cs Uses the shared warning filtering helper instead of a bespoke message check.
tests/dotnet/UnitTests/Extensions.cs Adds the shared filtering implementation (including Xcode-location deprecation warning filters).
tests/dotnet/UnitTests/BundleStructureTest.cs Threads platform through FilterWarnings(...) and delegates common filtering to Extensions.FilterWarnings(...).

Comment thread tests/dotnet/UnitTests/Extensions.cs
Comment thread tests/dotnet/UnitTests/BundleStructureTest.cs
@rolfbjarne

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) June 4, 2026 06:52
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #a8d91e4] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: a8d91e486e851421f2f9ad3f9c75eb921d72b46b [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: a8d91e486e851421f2f9ad3f9c75eb921d72b46b [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #a8d91e4] Build passed (Build packages) ✅

Pipeline on Agent
Hash: a8d91e486e851421f2f9ad3f9c75eb921d72b46b [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #a8d91e4] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: a8d91e486e851421f2f9ad3f9c75eb921d72b46b [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #a8d91e4] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 2 tests failed, 171 tests passed.

Failures

❌ introspection tests

1 tests failed, 5 tests passed.

Failed tests

  • introspection/macOS/Debug: Failed (Test run failed.
    Tests run: 34 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 0)

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

1 tests failed, 22 tests passed.

Failed tests

  • monotouch-test/macOS/Release (NativeAOT, x64): TimedOut (Execution timed out after 1200 seconds.
    Test run crashed)

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: a8d91e486e851421f2f9ad3f9c75eb921d72b46b [PR build]

@rolfbjarne

Copy link
Copy Markdown
Member Author

The test failures are unrelated.

@rolfbjarne rolfbjarne merged commit c513ce7 into main Jun 4, 2026
51 of 55 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/tests-xcodelocation-warnings branch June 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants