[src] Remove CIFilterGenerator from iOS and Mac Catalyst. by rolfbjarne · Pull Request #25630 · dotnet/macios

rolfbjarne · 2026-06-03T10:31:33Z

This is a macOS-only class.

But keep obsolete APIs throwing PlatformNotSupportedException until XAMCORE_5_0.

This is a macOS-only class. But keep obsolete APIs throwing PlatformNotSupportedException until XAMCORE_5_0.

rolfbjarne · 2026-06-03T10:37:22Z

/azp run

Copilot

Pull request overview

Removes the CIFilterGenerator binding from iOS and Mac Catalyst (keeping it macOS-only), while preserving source compatibility pre-XAMCORE_5_0 via an obsolete API surface that throws PlatformNotSupportedException.

Changes:

Removed CIFilterGenerator from iOS/Mac Catalyst xtro-sharpie ignore lists.
Updated the CoreImage binding definitions so CIFilterGenerator is macOS-only.
Added a legacy (pre-XAMCORE_5_0) iOS/Mac Catalyst stub type that throws PlatformNotSupportedException.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-CoreImage.ignore	Removes ignore entry now that `CIFilterGenerator` is no longer bound for Mac Catalyst in .NET.
tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreImage.ignore	Removes ignore entry now that `CIFilterGenerator` is no longer bound for iOS in .NET.
tests/introspection/ApiSelectorTest.cs	Removes special-case selector skipping for `CIFilterGenerator`.
src/frameworks.sources	Includes the new `CoreImage/CIFilterGenerator.cs` source file in the build.
src/CoreImage/CIFilterGenerator.cs	Adds an obsolete, PNSE-throwing stub for legacy iOS/Mac Catalyst builds (pre-`XAMCORE_5_0`).
src/coreimage.cs	Makes the `CIFilterGenerator` binding macOS-only by removing iOS/Mac Catalyst availability.

azure-pipelines · 2026-06-03T10:37:49Z

Azure Pipelines successfully started running 3 pipeline(s).

rolfbjarne · 2026-06-03T14:08:06Z

/azp run

azure-pipelines · 2026-06-03T14:08:39Z

Azure Pipelines successfully started running 3 pipeline(s).

rolfbjarne · 2026-06-04T13:05:25Z

/azp run

azure-pipelines · 2026-06-04T13:05:55Z

Azure Pipelines successfully started running 3 pipeline(s).

vs-mobiletools-engineering-service2 · 2026-06-04T13:21:04Z

✅ [PR Build #7290d27] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7290d27710e503a7076066ed3c611a03e56e5a9e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-04T13:31:11Z

✅ [PR Build #7290d27] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7290d27710e503a7076066ed3c611a03e56e5a9e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-04T13:32:39Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7290d27710e503a7076066ed3c611a03e56e5a9e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-04T13:41:09Z

✅ [PR Build #7290d27] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7290d27710e503a7076066ed3c611a03e56e5a9e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-04T15:31:34Z

🔥 [CI Build #7290d27] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 16 tests failed, 177 tests passed.

Failures

❌ introspection tests

4 tests failed, 2 tests passed.

Failed tests

introspection/iOS - simulator/Debug: LaunchTimedOut
introspection/iOS - simulator/Debug (ARM64): LaunchTimedOut
introspection/tvOS - simulator/Debug: LaunchTimedOut
introspection/tvOS - simulator/Debug (ARM64): LaunchTimedOut

Html Report (VSDrops) Download

❌ linker tests (tvOS)

11 tests failed, 0 tests passed.

Failed tests

dont link/tvOS - simulator/Debug: LaunchTimedOut
dont link/tvOS - simulator/Release: LaunchTimedOut
link sdk/tvOS - simulator/Debug: LaunchTimedOut
link sdk/tvOS - simulator/Release: LaunchTimedOut
link all/tvOS - simulator/Debug: LaunchTimedOut
link all/tvOS - simulator/Release: LaunchTimedOut
link all/tvOS - simulator/Debug (don't bundle original resources): LaunchTimedOut
trimmode copy/tvOS - simulator/Debug: LaunchTimedOut
trimmode copy/tvOS - simulator/Release: LaunchTimedOut
trimmode link/tvOS - simulator/Debug: LaunchTimedOut
trimmode link/tvOS - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ Tests on macOS Tahoe (26) tests

1 tests failed, 4 tests passed.

Failed tests

monotouch-test: Failed (exit code 2)
- No test failure details available. stderr output:
  - 2026-06-04 07:13:27.042 monotouchtest[72567:16714881] [PASS] VeryGeneric
  - 2026-06-04 07:13:27.043 monotouchtest[72567:16714881] [PASS] WrapperTypeLookupTest
  - 2026-06-04 07:13:27.043 monotouchtest[72567:16714881] Xamarin.Tests.RuntimeTest : 445.061 ms
  - 2026-06-04 07:13:27.043 monotouchtest[72567:16714881] Xamarin.Tests : 445.1138 ms
  - 2026-06-04 07:13:27.044 monotouchtest[72567:16714881] Xamarin : 452.5899 ms
  - 2026-06-04 07:13:27.044 monotouchtest[72567:16714881] bindings-test : 452.6576 ms
  - 2026-06-04 07:13:27.049 monotouchtest[72567:16713725] Tests run: 3601 Passed: 3585 Inconclusive: 16 Failed: 0 Ignored: 169
  - 2026-06-04 07:13:27.050 monotouchtest[72567:16713725] AutoRun (): completed test run on main thread
  - 2026-06-04 07:13:27.050 monotouchtest[72567:16713725] Exiting test run with success
  - make: *** [exec-monotouch-test] Error 1

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 7290d27710e503a7076066ed3c611a03e56e5a9e [PR build]

rolfbjarne · 2026-06-04T16:13:45Z

The test failures are unrelated.

[src] Remove CIFilterGenerator from iOS and Mac Catalyst.

3bfaf22

This is a macOS-only class. But keep obsolete APIs throwing PlatformNotSupportedException until XAMCORE_5_0.

Copilot AI review requested due to automatic review settings June 3, 2026 10:31

rolfbjarne enabled auto-merge (squash) June 3, 2026 10:31

Copilot started reviewing on behalf of rolfbjarne June 3, 2026 10:31 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread src/CoreImage/CIFilterGenerator.cs

This comment has been minimized.

Sign in to view

Add back

df501a9

rolfbjarne mentioned this pull request Jun 3, 2026

[xtro] Don't report !unknown-type! for types with an [UnsupportedOSPlatform] attribute. #25632

Merged

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jun 3, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/cifiltergenerator-removal

7290d27

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 15b2113 into main Jun 4, 2026
51 of 55 checks passed

rolfbjarne deleted the dev/rolf/cifiltergenerator-removal branch June 4, 2026 16:13

Conversation

rolfbjarne commented Jun 3, 2026

Uh oh!

rolfbjarne commented Jun 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 3, 2026

Uh oh!

azure-pipelines Bot commented Jun 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 4, 2026

✅ [PR Build #7290d27] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 4, 2026

✅ [PR Build #7290d27] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 4, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 4, 2026

✅ [PR Build #7290d27] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 4, 2026

🔥 [CI Build #7290d27] Test results 🔥

Test results

Failures

❌ introspection tests

Failed tests

❌ linker tests (tvOS)

Failed tests

❌ Tests on macOS Tahoe (26) tests

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

rolfbjarne commented Jun 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants