[tests] Ignore any tests using CFNetworkHandler. Fixes #25634.#25635
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR updates the monotouch-test HTTP-related test suites to stop running test cases that use System.Net.Http.CFNetworkHandler, due to known deadlocks in that handler (tracked in #25634). This keeps CI from hanging while preserving coverage for the supported handlers.
Changes:
- Mark
CFNetworkHandlerTestCaseinstances as ignored inMessageHandlers.csfor DNS failure and redirect/auth header scenarios. - Mark the
CFNetworkHandlerTestCaseas ignored inHttpClientTest.csfor the post-send modifiability test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/monotouch-test/System.Net.Http/MessageHandlers.cs | Ignores CFNetworkHandler test cases in two parameterized tests to avoid deadlocks. |
| tests/monotouch-test/HttpClient/HttpClientTest.cs | Ignores the CFNetworkHandler variant of a parameterized HttpClient handler test. |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #b33f741] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #b33f741] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #b33f741] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #b33f741] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 191 tests passed. Failures❌ monotouch tests (macOS) [attempt 5]2 tests failed, 21 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
|
Test failure is unrelated. |
There are known issues (deadlocks) with CFNetworkHandler: #25634
CFNetworkHandler is obsolete, so we won't fix any such issues, so to avoid deadlocks, just avoid testing CFNetworkHandler.
Fixes #25634.