[tests] Don't strip symbols on any platform.#25643
Conversation
`MtouchNoSymbolStrip` doesn't do anything on macOS, so use `NoSymbolStrip` instead.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Updates the monotouch-test .NET shared test project to use the cross-platform NoSymbolStrip MSBuild property instead of MtouchNoSymbolStrip, so symbol stripping is disabled consistently (including on macOS where MtouchNoSymbolStrip is ineffective).
Changes:
- Replace
<MtouchNoSymbolStrip>true</MtouchNoSymbolStrip>with<NoSymbolStrip>true</NoSymbolStrip>in the monotouch-test shared test project.
|
|
||
| <!-- Don't remove native symbols, because it makes debugging native crashes harder --> | ||
| <MtouchNoSymbolStrip>true</MtouchNoSymbolStrip> | ||
| <NoSymbolStrip>true</NoSymbolStrip> |
✅ [PR Build #d9e3ba5] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #d9e3ba5] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #d9e3ba5] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #d9e3ba5] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 17 tests failed, 176 tests passed. Failures❌ introspection tests [attempt 2]4 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests (tvOS) [attempt 2]11 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (macOS) [attempt 2]1 tests failed, 22 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS) [attempt 2]1 tests failed, 19 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
|
Test failures are unrelated. |
MtouchNoSymbolStripdoesn't do anything on macOS, so useNoSymbolStripinstead.