Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace/implement image comparison for device/unit tests #8661

Open
mattleibow opened this issue Jul 11, 2022 · 1 comment
Open

Replace/implement image comparison for device/unit tests #8661

mattleibow opened this issue Jul 11, 2022 · 1 comment
Labels
area-controls-image Image control area-testing Unit tests, device tests t/housekeeping ♻︎ Task neither bug nor feature but something that needs to be done in support of either testing-infrastructure Issue relating to testing infrastructure
Milestone
Backlog

Comments

@mattleibow
Copy link
Member

mattleibow commented Jul 11, 2022 •
edited
Loading

Description

We need a way to actually compare images - both on device and in unit tests - to make sure we have a way to test image differences.

I have some SkiaSharp diff code in the unit tests, but we need a way to generalize this so that we can test that changes to say a border thickness is correctly fixed in all the platforms.

Did you check if we could use an assertion library like Verify?

https://github.com/VerifyTests/Verify

Might simplify some of the test code.

There is an older one called ApprovalTests, but it only worked on Windows.

Originally posted by @jonathanpeppers in #8020 (comment)
@samhouts samhouts added area-image Image loading, sources, caching t/housekeeping ♻︎ area-testing Unit tests, device tests area-controls-image Image control labels Jul 12, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 12, 2022
@mattleibow mattleibow changed the title Replace image comparison with Verify Replace image comparison with Verify (or similar) May 19, 2023
@mattleibow mattleibow added this to the Backlog milestone May 19, 2023
@ghost
Copy link

ghost commented May 19, 2023

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@mattleibow mattleibow changed the title Replace image comparison with Verify (or similar) Replace/implement image comparison for device/unit tests Jul 5, 2023
@samhouts samhouts added the Task neither bug nor feature but something that needs to be done in support of either label Jul 31, 2023
@mattleibow mattleibow added the testing-infrastructure Issue relating to testing infrastructure label Dec 13, 2023
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-image Image loading, sources, caching labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-controls-image Image control area-testing Unit tests, device tests t/housekeeping ♻︎ Task neither bug nor feature but something that needs to be done in support of either testing-infrastructure Issue relating to testing infrastructure
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@Eilon @mattleibow @samhouts