Fixed android toolbar icon change #20166
Conversation
ghost
added
the
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Added UI Test. |
There was a problem hiding this comment.
This snapshot must be updated with the one generated by CI.
| .MoveTo(endX, endY) | ||
| .Wait(swipeSpeed) |
There was a problem hiding this comment.
Changes in the order of the actions to avoid a DriverException: Method has not yet been implemented.
| xmlns:ns="clr-namespace:Maui.Controls.Sample.Issues" | ||
| xmlns:android="clr-namespace:Microsoft.Maui.Controls.PlatformConfiguration.AndroidSpecific;assembly=Microsoft.Maui.Controls" | ||
| android:TabbedPage.ToolbarPlacement="Bottom"> | ||
| <local:Issue19673Page1 Title="Page 1" AutomationId="Page1" /> |
There was a problem hiding this comment.
Test based on the sample from #19673
kubaflo
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Similar PR here #16796 |
|
It would be fantastic if we also had a UI Test that matched the example provided in the description, it could even be a second one that covers #19950, that is, different icons and text being displayed. As seen below, it looks like the test is checking if one icon set on one page is persisting across the others. 19673.webm |
kubaflo
force-pushed
the
android-toolbar-icon-update-fix
branch
from
0a31c4b
to
d603b16
Compare
|
@dustin-wojciechowski I've added a Ui Test that covers the #19950 bug like you asked for :) |
|
/rebase |
github-actions
bot
force-pushed
the
android-toolbar-icon-update-fix
branch
from
d603b16
to
cb02b5b
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
|
@jfversluis yes, I don't think we need it anymore. Therefore, I'm closing this pr :) |
Description of Change
Fixed android toolbar icon change on shell pages
Issues Fixed
Fixes #19673
Fixes #19950
Screen.Recording.2024-01-26.at.01.17.15.mov