Skip to content

[Android] Changes to avoid an EditText issue with RecyclerView scroll #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022
Merged

[Android] Changes to avoid an EditText issue with RecyclerView scroll #5003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Compatibility/Core/src/Android/Renderers/EditorRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ protected override void UpdateTextColor()
_textColorSwitcher.UpdateTextColor(EditText, Element.TextColor);
}

[PortHandler]
protected override void OnAttachedToWindow()
{
base.OnAttachedToWindow();
Expand Down
12 changes: 12 additions & 0 deletions src/Core/src/Handlers/Editor/EditorHandler.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,14 @@ protected override AppCompatEditText CreatePlatformView()

protected override void ConnectHandler(AppCompatEditText platformView)
{
platformView.ViewAttachedToWindow += OnPlatformViewAttachedToWindow;
platformView.TextChanged += OnTextChanged;
platformView.FocusChange += OnFocusedChange;
}

protected override void DisconnectHandler(AppCompatEditText platformView)
{
platformView.ViewAttachedToWindow -= OnPlatformViewAttachedToWindow;
platformView.TextChanged -= OnTextChanged;
platformView.FocusChange -= OnFocusedChange;
}
Expand Down Expand Up @@ -87,6 +89,16 @@ public static void MapCursorPosition(IEditorHandler handler, ITextInput editor)
public static void MapSelectionLength(IEditorHandler handler, ITextInput editor) =>
handler.PlatformView?.UpdateSelectionLength(editor);

void OnPlatformViewAttachedToWindow(object? sender, ViewAttachedToWindowEventArgs e)
{
if (PlatformView.IsAlive() && PlatformView.Enabled)
{
// https://issuetracker.google.com/issues/37095917
PlatformView.Enabled = false;
PlatformView.Enabled = true;
}
}

void OnTextChanged(object? sender, Android.Text.TextChangedEventArgs e) =>
VirtualView?.UpdateText(e);

Expand Down