Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AbsoluteLayout children to auto size when height/width are not proportional #7183

Merged
merged 1 commit into from May 16, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented May 14, 2022

Description of Change

When the height/width layout parameters from AbsoluteLayout are set to AutoSize, the current implementation still restricts the child to the width/height of the AbsoluteLayout, rather than allowing it to size itself.

These changes allow the child to size itself.

Note that this will be a behavioral change from Forms, which has had the "not actually auto-sizing" bug for a while. In most situations this will not be noticeable, as the bugged sizing and correct sizing happen to be the same. For situations where the bugged sizing is preferred, it can be be achieved by setting values of 1 for WidthProportional and HeightProportional.

For the moment, the Compatibility version of the AbsoluteLayout retains the old, bugged behavior.

Issues Fixed

Fixes #6500

@jsuarezruiz jsuarezruiz added the area/layout 🔲 label May 16, 2022
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented May 16, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 16, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow mattleibow added this to the 6.0.300-servicing milestone May 16, 2022
@hartez hartez merged commit 76a532b into main May 16, 2022
24 checks passed
@hartez hartez deleted the fix-6500 branch May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/layout 🔲
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants