Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StepperHandler in WinUI #777

Merged
merged 7 commits into from May 27, 2021
Merged

Implement StepperHandler in WinUI #777

merged 7 commits into from May 27, 2021

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Apr 19, 2021 •
edited

Description of Change

Implement StepperHandler in WinUI

  • Minimum
  • Maximum
  • Interval
  • Value

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

No

rachelkang
rachelkang reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the Stepper show up when I run the WinUI sample :(

src/Core/src/Platform/Windows/MauiStepper.cs
public static readonly DependencyProperty MinimumProperty =
DependencyProperty.Register("Minimum", typeof(double), typeof(MauiStepper), new PropertyMetadata(default(double), OnMaxMinChanged));

public static readonly DependencyProperty IncrementProperty =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartez was this ever renamed? I remember some discussion somewhere about potentially renaming to Interval instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we renamed it in MAUI Core. I'm less concerned with what it's called here on the native platform, but if it's not a breaking change then it might be nice to keep it consistent.

@jsuarezruiz
Copy link
Contributor Author

Rebased with the latest changes in main.
winui-stepper

@hartez
Copy link
Contributor

hartez commented May 26, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hartez hartez merged commit 827424d into main May 27, 2021
@hartez hartez deleted the winui-stepper branch May 27, 2021 00:15
lytico pushed a commit to lytico/maui that referenced this pull request Jun 8, 2021
@jsuarezruiz @rmarinho @lytico
Implement StepperHandler in WinUI (dotnet#777)
14cac7a 
* Implement StepperHandler in WinUI

* Register Stepper ResourceDictionary

* Removed sealed from MauiStepper class

Co-authored-by: Rui Marinho <me@ruimarinho.net>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez left review comments

@rmarinho rmarinho rmarinho left review comments

@rachelkang rachelkang rachelkang left review comments

Assignees
No one assigned
Labels
platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsuarezruiz @hartez @rmarinho @rachelkang