New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the iOS ScrollView content container is at least the ScrollView size #8451
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
The device test failure is unrelated and @PureWeen has a fix coming. |
…w size (#8451) Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Has this fix also been merged into net7.0 ? I am seeing this behavior on iOS using a VericalStackLayout as a BindableLayout inside a ScrollView. The ScrollView also contains a button, used to add a new element to the collection that the BindableLayout is bound to. So the process is 1. the button works, 2. the user clicks the button, 3. a new element is added to the bound collection and so it is displayed in the BindableLayout, 4. rinse and repeat until the button is pushed off the bottom of the screen, 5. click events stop firing. If the button is half-on and half-off the display, you can scroll it to be fully visible, but only the top half responds to click events. |
Yes, it was merged before net7.0 was first released.
I think you're seeing a newer bug that's popped up: #14624 |
Description of Change
For various reasons, the ScrollView is using a container ContentView to hold all the stuff in the ScrollView on iOS. If the container isn't large enough for the content, the content will still layout and display just fine, but the hit testing won't work for any part of the content outside the bounds of the container.
These changes ensure that the container is large enough to contain the content so that the hit testing works. They also fix an issue where ScrollView content did not properly account for SafeArea (drawing some content outside the safe area even when the content requested otherwise), and fix an issue where vertical alignments other than Fill were slightly off-alignment inside of ScrollView (when the content itself was smaller than the viewport size).
Issues Fixed
Fixes #8446