Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile satellite resource assemblies for Windows' pseudo-locales #3653

Closed
martincostello opened this issue Aug 25, 2018 · 1 comment
Closed

Comments

@martincostello
Copy link
Contributor

@martincostello martincostello commented Aug 25, 2018

Steps to reproduce

To replicate view the https://github.com/martincostello/msbuild-pseudo-locale-repro GitHub repo and follow the instructions in the README.

Expected behavior

The compilation output includes the following files:

./PseudoLocales/bin/Debug/netcoreapp2.1/PseudoLocales.dll.
./PseudoLocales/bin/Debug/netcoreapp2.1/PseudoLocales.pdb.
./PseudoLocales/bin/Debug/netcoreapp2.1/fr/PseudoLocales.resources.dll.
./PseudoLocales/bin/Debug/netcoreapp2.1/qps-ploc/PseudoLocales.resources.dll.

Actual behavior

The compilation output includes the following files:

./PseudoLocales/bin/Debug/netcoreapp2.1/PseudoLocales.dll.
./PseudoLocales/bin/Debug/netcoreapp2.1/PseudoLocales.pdb.
./PseudoLocales/bin/Debug/netcoreapp2.1/fr/PseudoLocales.resources.dll.

The following file is not emitted:

./PseudoLocales/bin/Debug/netcoreapp2.1/qps-ploc/PseudoLocales.resources.dll.

Environment data

msbuild /version output:

Microsoft (R) Build Engine version 15.8.166+gd4e8d81a88 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

15.8.166.59604

OS info:

.NET Core SDK (reflecting any global.json):
 Version:   2.1.401
 Commit:    91b1c13032

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17134
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.401\

Host (useful for support):
  Version: 2.1.3
  Commit:  124038c13e
@martincostello
Copy link
Contributor Author

@martincostello martincostello commented Aug 25, 2018

Raised PR with suggested fix as #3654.

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Sep 5, 2018
* Support Windows pseudo-locales

Add support for Windows pseudo-locales so that satellite resource assemblies can be compiled for them.

* Update HardcodedCultureNames

Update HardcodedCultureNames by regenerating it using the generated since removed from aspnet/Localization (see aspnet/Localization#130).

Closes dotnet#3653
@cdmihai cdmihai closed this in 21fb999 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant