Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files from the repo #6158

Merged
merged 6 commits into from Mar 11, 2021
Merged

Conversation

@Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented Feb 16, 2021

Fixes #6190

Context

Remove unused projects and files in the repo. Part of the larger refactoring that'll lead into #1686

Changes Made

  • Remove unused netci.groovy file.
  • Remove unused RunApiPort.bat file.
  • Remove unused runApiCompat.bat file.
  • Remove unused CompatBaseline.txt file.
  • Remove unused src\Tasks\DefaultTasks.bat file.
  • Remove unused src\Tasks.UnitTests2 project.

Testing

NIL

Notes

  • DefaultTasks.bat file.
  • Tasks.UnitTests2 project.

These are a part of XMake project in VS repo.
These are not used in the build process in this repo.

Copy link
Member

@Forgind Forgind left a comment

LGTM! Thanks!

Nirmal4G added 6 commits Feb 12, 2020
This is a part of XMake project in VS repo.
This is not used here in this MSBuild repo.
Replaced with Azure Pipelines and Arcade Sdk
No longer needed. Replaced with dotnet tool.
No longer needed. Replaced with dotnet tool.
This batch file was used to copy targets for VS insertion in the old MSBuild project in VS repo.
This is no longer needed as we achieve this using custom build logic in the project file itself.
Used when merging xplat branch.
No longer needed.
@Nirmal4G Nirmal4G force-pushed the Nirmal4G:hotfix/remove-unused branch from d68f5b7 to 0d464c6 Mar 2, 2021
@Nirmal4G Nirmal4G changed the title Remove Unused Tasks.UnitTests2 project Remove unused files from the repo Mar 2, 2021
@Forgind
Forgind approved these changes Mar 4, 2021
Copy link
Member

@BenVillalobos BenVillalobos left a comment

LGTM!

@rokonec rokonec merged commit 8d4134b into dotnet:master Mar 11, 2021
7 checks passed
7 checks passed
license/cla All CLA requirements met.
Details
@azure-pipelines
msbuild-pr Build #20210302.2 succeeded
Details
@azure-pipelines
msbuild-pr (Linux Core) Linux Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Core) Windows Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full Release (no bootstrap)) Windows Full Release (no bootstrap) succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full) Windows Full succeeded
Details
@azure-pipelines
msbuild-pr (macOS Core) macOS Core succeeded
Details
@Nirmal4G Nirmal4G deleted the Nirmal4G:hotfix/remove-unused branch Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants