Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup whitespace and new lines in Common props, targets and tasks #6159

Merged

Conversation

@Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented Feb 16, 2021

Part of #4779

Context

Make Common props, targets and tasks easier to read and understand.
Fixup whitespace and new lines only in Common props, targets and tasks files.

Part of the larger refactoring that'll lead into #1686

Changes Made

  • Remove all trailing spaces
  • Fixup new lines where necessary
    • Add new lines between every block to make it clear.
    • Remove unnecessary new lines to reduce scrolling.

Notes

I'll also make sure not to mess up the git blame too much.
To make reviewing easier, I had split up the changes logically rather than a file.
Also, please do not that these changes won't make much difference alone but with other formatting and refactors that follow this will make a world of difference in reading these files.

Nirmal4G added 2 commits Apr 3, 2020
only in MSBuild Common props, targets and tasks files

Conforming to the repository's EditorConfig file
only in MSBuild Common props, targets and tasks files

Add New Line(s) between every block to make it clear.
Remove unnecessary New Line(s) to reduce scrolling.
@Nirmal4G Nirmal4G changed the title Fixup whitespace and new lines in Common props, targets and tasks files Fixup whitespace and new lines in Common props, targets and tasks Feb 16, 2021
Copy link
Member

@KirillOsenkov KirillOsenkov left a comment

I looked through and the changes look good to me

@Forgind
Forgind approved these changes Mar 1, 2021
@BenVillalobos BenVillalobos merged commit 4144194 into dotnet:master Mar 4, 2021
7 checks passed
7 checks passed
license/cla All CLA requirements met.
Details
@azure-pipelines
msbuild-pr Build #20210216.1 succeeded
Details
@azure-pipelines
msbuild-pr (Linux Core) Linux Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Core) Windows Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full Release (no bootstrap)) Windows Full Release (no bootstrap) succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full) Windows Full succeeded
Details
@azure-pipelines
msbuild-pr (macOS Core) macOS Core succeeded
Details
@Nirmal4G Nirmal4G deleted the Nirmal4G:hotfix/core-sdk-prep/cleanup-whitespace branch Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants