Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ready To Run option for ClickOnce publish #6244

Merged
merged 1 commit into from Mar 13, 2021

Conversation

@sujitnayak
Copy link
Contributor

@sujitnayak sujitnayak commented Mar 11, 2021

Fixes #

Context

VS Publish providers supports an option called ReadyToRun (R2R) by compiling application assemblies as ReadyToRun format.
ClickOnce publishing does not support this option.

Changes Made

The change adds support for enabling R2R option in ClickOnce publish.

To do so, the _DeploymentComputeClickOnceManifestInfo ClickOnce target checks the PublishReadyToRun property when PublishSingleFile is not enabled (loose files scenario). If it is true, then it will replace the R2R'ed assemblies within ClickOnceFile group with the corresponding R2R assemblies from the obj...\R2R folder.

In addition, it calls SignFile task to sign the R2R application image.

Testing

CTI has testing the R2R configuration with top 50 NuGet packages. In addtion, other normal ClickOnce publish scenarios have been tested with top 50 NuGet packages for regresssions.

Notes

Risk: Low since change are scoped to the ReadyToRun scenario only.

@sujitnayak sujitnayak requested a review from John-Hart Mar 11, 2021
@John-Hart John-Hart requested a review from ning51 Mar 11, 2021
@sujitnayak sujitnayak merged commit 80b7f2d into dotnet:master Mar 13, 2021
7 checks passed
7 checks passed
license/cla All CLA requirements met.
Details
@azure-pipelines
msbuild-pr Build #20210311.10 succeeded
Details
@azure-pipelines
msbuild-pr (Linux Core) Linux Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Core) Windows Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full Release (no bootstrap)) Windows Full Release (no bootstrap) succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full) Windows Full succeeded
Details
@azure-pipelines
msbuild-pr (macOS Core) macOS Core succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants