Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning detailed summary off #6338

Merged
merged 2 commits into from Apr 20, 2021
Merged

Conversation

@KirillOsenkov
Copy link
Member

@KirillOsenkov KirillOsenkov commented Apr 10, 2021

Change the DetailedSummary command-line switch from parameterless to parameterized, allowing the user to have control and explicitly set it to false if needed, overriding the default of true when the verbosity is diagnostic.

This is backwards compatible with the previous behavior, so if /ds is specified, it is equivalent to turning it on.

Fixes #4409

Change the DetailedSummary command-line switch from parameterless to parameterized, allowing the user to have control and explicitly set it to false if needed, overriding the default of true when the verbosity is diagnostic.

This is backwards compatible with the previous behavior, so if /ds is specified, it is equivalent to turning it on.

Fixes #4409
@cdmihai
Copy link
Contributor

@cdmihai cdmihai commented Apr 15, 2021

Is it worth adding some code to automatically turn the detailed summary off if:

  • /bl set AND
  • diagnostic verbosity was not present in the cmdline args AND
  • /ds was not explicitly present in the cmdline args
@KirillOsenkov
Copy link
Member Author

@KirillOsenkov KirillOsenkov commented Apr 19, 2021

@cdmihai perhaps; but probably should be done in a separate PR. This PR just makes the detailedSummary switch parameterized, which is good to have regardless. I think it can be useful in general.

@BenVillalobos BenVillalobos merged commit 13452c0 into main Apr 20, 2021
7 checks passed
7 checks passed
license/cla All CLA requirements met.
Details
@azure-pipelines
msbuild-pr Build #20210410.2 succeeded
Details
@azure-pipelines
msbuild-pr (Linux Core) Linux Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Core) Windows Core succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full Release (no bootstrap)) Windows Full Release (no bootstrap) succeeded
Details
@azure-pipelines
msbuild-pr (Windows Full) Windows Full succeeded
Details
@azure-pipelines
msbuild-pr (macOS Core) macOS Core succeeded
Details
@BenVillalobos BenVillalobos deleted the dev/kirillo/detailedSummary branch Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants