Log ETW for SDK resolution again #9393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://learn.microsoft.com/dotnet/api/system.diagnostics.tracing.eventsource#conventions, the version field for events must increment any time the payload is added to. I looked at https://github.com/dotnet/msbuild/blame/31c4d335325e858a3c4dba66d921d0e31bdee5ff/src/Framework/MSBuildEventSource.cs and added a version bump to every event that wasn't from 45e27c1, ad3e7d0, or an introduction of the event, and found only this one.
`EventSource.WriteEvent()` can, instead of writing the specified event, instead create `Microsoft-Build/EventSourceMessage` events that look like ``` EventSourceException while processing event "SdkResolverResolveSdkStop": Null passed as a event argument. EventSourceException while processing event "CachedSdkResolverServiceResolveSdkStop": Null passed as a event argument. ``` Fix all instances of this by enabling nullable analysis in `MSBuildEventSource.cs` and then fixing the errors that arose. Fixes dotnet#8519.
|
v1 of this fix is incomplete, because it didn't actually fix |
Tried #9395 but I think our normal build with the text perf log doesn't fire enough of the events to catch the SDK ones that are known (now) to be broken. |
Forgind
reviewed
Nov 6, 2023
src/Build/BackEnd/Components/ProjectCache/ProjectCacheService.cs
Outdated
Show resolved
Hide resolved
f-alizada
reviewed
Nov 9, 2023
src/Build/BackEnd/Components/ProjectCache/ProjectCacheService.cs
Outdated
Show resolved
Hide resolved
Forgind
approved these changes
Nov 10, 2023
rokonec
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventSource.WriteEvent()can, instead of writing the specified event, instead createMicrosoft-Build/EventSourceMessageevents that look likeFix instances of this by enabling nullable analysis in
MSBuildEventSource.csand then fixing the errors that arose.Fixes #8519.
While investigating this I noticed one event that had had a field added but no version bump, so I fixed that too.
With this change I see events: