From 656f54abc6bd28c46446d3c39c37d7f8477c5c61 Mon Sep 17 00:00:00 2001 From: ReubenBond Date: Tue, 21 May 2024 18:56:44 -0700 Subject: [PATCH] Add comments to test types and rename to suit --- .../CodeGenTests/IRuntimeCodeGenGrain.cs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs b/test/DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs index bc3da0c948..0c501987de 100644 --- a/test/DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs +++ b/test/DefaultCluster.Tests/CodeGenTests/IRuntimeCodeGenGrain.cs @@ -8,21 +8,22 @@ namespace Tester.CodeGenTests using Orleans; using Orleans.Providers; - public interface ISomeInterface + // Regression test for explicit interface method implementations https://github.com/dotnet/orleans/issues/8991 + public interface IExplicitOverridesTestGenericBase { Task M(T arg); } - public interface IBase : ISomeInterface; + public interface IExplicitOverridesTestBase : IExplicitOverridesTestGenericBase; - public interface IDerived : IBase, ISomeInterface + public interface IExplicitOverridesTestDerived : IExplicitOverridesTestBase, IExplicitOverridesTestGenericBase { - Task ISomeInterface.M(object obj) => M(obj); + Task IExplicitOverridesTestGenericBase.M(object obj) => M(obj); } - public interface ISomeGrainWithExplicitImplementation : IDerived, IGrainWithGuidKey; + public interface IExplicitOverridesTestImplementation : IExplicitOverridesTestDerived, IGrainWithGuidKey; - public class SomeGrain : Grain, ISomeGrainWithExplicitImplementation + public class ExplicitOverridesTestGrain : Grain, IExplicitOverridesTestImplementation { public Task M(string arg) { @@ -30,6 +31,8 @@ public Task M(string arg) } } + // End regression test for https://github.com/dotnet/orleans/issues/8991 + public interface IGrainWithGenericMethods : IGrainWithGuidKey { Task GetTypesExplicit();