Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (or workaround?) for codegen using netcore/netstandard 2.1 #4673

Merged
merged 7 commits into from Jun 13, 2018

Conversation

Projects
None yet
6 participants
@benjaminpetit
Copy link
Contributor

benjaminpetit commented Jun 8, 2018

Fix for #4585

@sergeybykov sergeybykov changed the title Fix (or workaround?) for codegen using netcore/netstandard 2.1 [VIP] Fix (or workaround?) for codegen using netcore/netstandard 2.1 Jun 8, 2018

@sergeybykov sergeybykov changed the title [VIP] Fix (or workaround?) for codegen using netcore/netstandard 2.1 [WIP] Fix (or workaround?) for codegen using netcore/netstandard 2.1 Jun 8, 2018

@sergeybykov sergeybykov changed the title [WIP] Fix (or workaround?) for codegen using netcore/netstandard 2.1 Fix (or workaround?) for codegen using netcore/netstandard 2.1 Jun 13, 2018

@@ -4,6 +4,11 @@
<RootNamespace>TestFSharp</RootNamespace>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">

This comment has been minimized.

@sergeybykov

sergeybykov Jun 13, 2018

Member

We probably don't need this because there's already the change in Directory.Build.props.

@@ -4,6 +4,12 @@
<RootNamespace>TestFSharpInterfaces</RootNamespace>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

This comment has been minimized.

@sergeybykov

sergeybykov Jun 13, 2018

Member

We probably don't need this because there's already the change in Directory.Build.props.

@sergeybykov sergeybykov merged commit 74695f5 into dotnet:master Jun 13, 2018

3 of 4 checks passed

functional Started.
Details
Ubuntu16.04 Release Build Build finished.
Details
WIP ready for review
Details
bvt Build finished.
Details

ReubenBond added a commit that referenced this pull request Jun 15, 2018

Use netcoreapp2.0 for msbuild target dll if using dotnet core msbuild…
… but targeting full .net (#4689)

#4673 introduced a regression: when using the command `dotnet build` to build project that target the full .NET framework, the variable for `CoreAssembly` is not set, and the variable `TaskAssembly` depends on it.

The easiest workaround here is to always fallback to 2.0 dll

Maybe we could instead removing this task dependency, and rely on the fact that we should find the `dotnet` command in the path @ReubenBond ?
@andtii

This comment has been minimized.

Copy link

andtii commented Jul 10, 2018

@sergeybykov When will this be released? At the moment i cant use Orleans with .net 2.1

@ReubenBond

This comment has been minimized.

Copy link
Contributor

ReubenBond commented Jul 10, 2018

@andtii could you confirm that you're able to build your solution using the nightly build packages available on MyGet? Instructions here: https://github.com/dotnet/orleans#official-builds

We will try to release 2.0.4 with these fixes this week.

@ReubenBond

This comment has been minimized.

Copy link
Contributor

ReubenBond commented Jul 10, 2018

Opened #4754 to pull this into 2.0.4

@galvesribeiro

This comment has been minimized.

Copy link
Member

galvesribeiro commented Jul 10, 2018

@muxa

This comment has been minimized.

Copy link
Contributor

muxa commented Jul 22, 2018

@benjaminpetit

This comment has been minimized.

Copy link
Contributor Author

benjaminpetit commented Jul 23, 2018

@muxa yes we forgot to publish this package. We will try to publish later today or tomorrow

@galvesribeiro

This comment has been minimized.

Copy link
Member

galvesribeiro commented Jul 24, 2018

I just confirmed that using the latest MyGet version:

[assembly: AssemblyInformationalVersion("2.0.4-ci.20180721.1. Commit Hash: 839e953")]

Still doesn't work and throw the same errors if used with netcoreapp2.1:

https://gist.github.com/galvesribeiro/e231ab7e08e19d4c40c5b9493e5ee0d3

I wonder if the problem is really fixed and worth this package to be published...

benjaminpetit added a commit to benjaminpetit/orleans that referenced this pull request Aug 27, 2018

Use netcoreapp2.0 for msbuild target dll if using dotnet core msbuild…
… but targeting full .net (dotnet#4689)

dotnet#4673 introduced a regression: when using the command `dotnet build` to build project that target the full .NET framework, the variable for `CoreAssembly` is not set, and the variable `TaskAssembly` depends on it.

The easiest workaround here is to always fallback to 2.0 dll

Maybe we could instead removing this task dependency, and rely on the fact that we should find the `dotnet` command in the path @ReubenBond ?

ReubenBond added a commit that referenced this pull request Aug 27, 2018

Use netcoreapp2.0 for msbuild target dll if using dotnet core msbuild…
… but targeting full .net (#4689) (#4895)

#4673 introduced a regression: when using the command `dotnet build` to build project that target the full .NET framework, the variable for `CoreAssembly` is not set, and the variable `TaskAssembly` depends on it.

The easiest workaround here is to always fallback to 2.0 dll

Maybe we could instead removing this task dependency, and rely on the fact that we should find the `dotnet` command in the path @ReubenBond ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.