Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for CoreFx/#30781 (Fixes #4505) #4736

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
3 participants
@ReubenBond
Copy link
Contributor

ReubenBond commented Jul 3, 2018

Fixes #4505

This implements a workaround for some divergent behavior between .NET Core and .NET Framework tracked by dotnet/corefx#30781

Note that this is intended for a 2.0.4 release.

@ReubenBond ReubenBond added this to the 2.0.4 milestone Jul 3, 2018

@ReubenBond ReubenBond force-pushed the ReubenBond:workaround-corefx-concurrentbag branch to ac41718 Jul 3, 2018

@jdom

jdom approved these changes Jul 3, 2018

@jdom

This comment has been minimized.

Copy link
Member

jdom commented Jul 3, 2018

CI is not running against this branch. Is this just a cherrypick of something that is already on master? If not, shouldn't this be on master first?

@benjaminpetit

This comment has been minimized.

Copy link
Contributor

benjaminpetit commented Jul 3, 2018

CI is not running against this branch. Is this just a cherrypick of something that is already on master? If not, shouldn't this be on master first?

I think it doesn't make sense to put it in master, since this fix is not applicable with the change to the scheduler, do you confirm Reuben?

@ReubenBond

This comment has been minimized.

Copy link
Contributor Author

ReubenBond commented Jul 3, 2018

Yes, this fix is only for the old scheduler. We can run tests in VSO instead.

@benjaminpetit benjaminpetit merged commit 56ae21d into dotnet:2.0.4 Jul 5, 2018

2 checks passed

WIP ready for review
Details
license/cla All CLA requirements met.
Details

@ReubenBond ReubenBond deleted the ReubenBond:workaround-corefx-concurrentbag branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.