Do not try to register GrainVersionStore if an implementation of IVersionStore is already registered #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sionStore is already registered
|
@dotnet-bot test functional |
ReubenBond
reviewed
Aug 29, 2018
| @@ -171,8 +172,11 @@ internal static void AddDefaultServices(HostBuilderContext context, IServiceColl | |||
| services.TryAddSingleton<VersionSelectorManager>(); | |||
| services.TryAddSingleton<CachedVersionSelectorManager>(); | |||
| // Version selector strategy | |||
| services.TryAddSingleton<GrainVersionStore>(); | |||
| services.AddFromExisting<IVersionStore, GrainVersionStore>(); | |||
There was a problem hiding this comment.
This can be TryAddFromExisting instead
There was a problem hiding this comment.
Mhh I would prefer not to register GrainVersionStore if it is not needed. I guess I could add a new helper method?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4855