[WIP] Remove catalog activations locking #5526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/locking-catalog
branch
from
65496e9
to
cfd0c4b
Compare
xiazen
reviewed
Apr 11, 2019
| @@ -443,20 +439,19 @@ public void GetGrainTypeInfo(int typeCode, out string grainClass, out PlacementS | |||
| activatedPromise = Task.CompletedTask; | |||
| PlacementStrategy placement; | |||
|
|
|||
| lock (activations) | |||
| while (true) | |||
There was a problem hiding this comment.
this smells bad. why are we adding infinite retry here while the original logic didn't?
There was a problem hiding this comment.
this is a standard lock-free approach when dealing with optimistic concurrency conflicts
In reply to: 274565380 [](ancestors = 274565380)
There was a problem hiding this comment.
I see. Thanks for explaining !
can this be called concurrently or is this single threaded? Because if it's the first option, you'll have to use some kind of locking primitive, not necessarily on Refers to: src/Orleans.Runtime/Catalog/Catalog.cs:1383 in cfd0c4b. [](commit_id = cfd0c4b, deletion_comment = False) |
xiazen
approved these changes
Apr 11, 2019
ReubenBond
changed the title
ReubenBond
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.