Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test glitch in PersistenceProvider_Memory_FixedLatency_WriteRead #6378

Conversation

jthelin
Copy link
Member

@jthelin jthelin commented Mar 3, 2020

Failure mode:

Write: Expected minimum latency = 00:00:00.2000000 Actual = 00:00:00.1975619

 at Tester.AzureUtils.Persistence.PersistenceProviderTests_Local.PersistenceProvider_Memory_FixedLatency_WriteRead()
    in C:\agent\_work\2\s\test\Extensions\TesterAzureUtils\Persistence\PersistenceProviderTests.cs:line 237

This looks to be caused by a simple system clock resolution / rounding error edge case glitch in the test code.

This is a fix for a test glitch encountered with running Functional tests for PR #6374

Failure mode:
```
Write: Expected minimum latency = 00:00:00.2000000 Actual = 00:00:00.1975619

 at Tester.AzureUtils.Persistence.PersistenceProviderTests_Local.PersistenceProvider_Memory_FixedLatency_WriteRead()
    in C:\agent\_work\2\s\test\Extensions\TesterAzureUtils\Persistence\PersistenceProviderTests.cs:line 237

```

This looks to be caused by a simple system clock resolution / rounding error edge case glitch in the test code.
@sergeybykov sergeybykov merged commit 1228928 into dotnet:master Mar 3, 2020
@jthelin jthelin deleted the Test-glitch-PersistenceProvider_Memory_FixedLatency_WriteRead branch March 3, 2020 03:29
sergeybykov pushed a commit to sergeybykov/orleans that referenced this pull request Apr 24, 2020
ReubenBond pushed a commit that referenced this pull request May 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants