Skip to content

Conversation

@matouskozak
Copy link
Member

@matouskozak matouskozak commented Sep 29, 2025

  • Adding more logging for easier debugging straight from the azdo logs
  • Add fallback to previous feed (dotnet11 -> dotnet10) if latest feed doesn't contain needed packages
  • Add hard error when MAUI workload install fails
  • Move package parsing to precommands.py

Example build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2804404

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the MAUI workload installation process to improve reliability and debugging capabilities. The changes add comprehensive logging, implement a fallback mechanism for package feeds, and move JSON parsing logic for better error handling.

  • Enhanced error handling and logging throughout the MAUI workload installation process
  • Added fallback from latest dotnet feed (dotnet11) to previous version (dotnet10) when packages are not found
  • Moved package search JSON parsing logic from mauisharedpython.py to precommands.py for better error handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/scenarios/shared/precommands.py Added JSON parsing logic to get_packages_for_sdk_from_feed method and enhanced workload installation error handling
src/scenarios/shared/mauisharedpython.py Enhanced logging throughout MAUI installation process and implemented fallback feed mechanism

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This should help a lot with debugging when the builds fail.

@LoopedBard3 LoopedBard3 merged commit 44f9c87 into dotnet:main Sep 29, 2025
72 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants